Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Hi, Thinh Nguyen writes: > Try to dequeue a request that was already completed. Odd. Why are we > missing a call to giveback?? Got a little more information: file-storage-3982 [006] d... 131.010663: dwc3_ep_queue: ep1in: req eccaa10f length 0/16384 zsI

Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Hi Felipe, On 1/21/2019 4:15 AM, Felipe Balbi wrote: > Hi > > Felipe Balbi writes: >> Hi, >> >> Felipe Balbi writes: >>> Hi again, >>> >>> Felipe Balbi writes: >>> >>> >>> Try to dequeue a request that was already completed. Odd. Why are we missing a call to giveback?? >>> Got a litt

Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Hi Felipe Balbi writes: > Hi, > > Felipe Balbi writes: >> Hi again, >> >> Felipe Balbi writes: >> >> >> >>> Try to dequeue a request that was already completed. Odd. Why are we >>> missing a call to giveback?? >> >> Got a little more information: >> >> file-storage-3982 [006] d... 131.

Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Hi, Felipe Balbi writes: > Hi again, > > Felipe Balbi writes: > > > >> Try to dequeue a request that was already completed. Odd. Why are we >> missing a call to giveback?? > > Got a little more information: > > file-storage-3982 [006] d... 131.010663: dwc3_ep_queue: ep1in: req > 00

Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Hi again, Felipe Balbi writes: > Try to dequeue a request that was already completed. Odd. Why are we > missing a call to giveback?? Got a little more information: file-storage-3982 [006] d... 131.010663: dwc3_ep_queue: ep1in: req eccaa10f length 0/16384 zsI ==> -115 fil

Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Hi, Thinh Nguyen writes: > On 1/17/2019 11:12 PM, Felipe Balbi wrote: >> Hi, >> >> Thinh Nguyen writes: >>> @@ -1409,15 +1407,11 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep, >>> if (r == req) { >>> /* wait until it is processed */ >>>

Re: [PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Hi, Thinh Nguyen writes: > @@ -1409,15 +1407,11 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep, > if (r == req) { > /* wait until it is processed */ > dwc3_stop_active_transfer(dep, true); > > I ran into a regression with th

[PATCH 10/14] usb: dwc3: gadget: remove wait_end_transfer

Now that we have a list of cancelled requests, we can skip over TRBs when END_TRANSFER command completes. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.h | 3 --- drivers/usb/dwc3/gadget.c | 40 +-- 2 files changed, 1 insertion(+), 42 deletions(-)