Re: [PATCH 1/3] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-29 Thread Sebastian Andrzej Siewior
On 08/29/2012 01:37 PM, Michal Nazarewicz wrote: On 08/28/2012 11:45 PM, Michal Nazarewicz wrote: +#define USB_GADGET_COMPOSITE_OPTIONS() \ + static struct usb_composite_overwrite coverwrite; \ I would probably use something longer for the va

Re: [PATCH 1/3] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-29 Thread Michal Nazarewicz
> On 08/28/2012 11:45 PM, Michal Nazarewicz wrote: >>> +#define USB_GADGET_COMPOSITE_OPTIONS() >>> \ >>> + static struct usb_composite_overwrite coverwrite; \ >> >> I would probably use something longer for the variable name, but that's >> just m

Re: [PATCH 1/3] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-29 Thread Sebastian Andrzej Siewior
On 08/28/2012 11:45 PM, Michal Nazarewicz wrote: +#define USB_GADGET_COMPOSITE_OPTIONS() \ + static struct usb_composite_overwrite coverwrite; \ I would probably use something longer for the variable name, but that's just me. :) What do you

Re: [PATCH 1/3] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-28 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch moves the module options idVendor, idProduct and bcdDevice > from composite.c into each gadgets. This ensures compatibility with > current gadgets and removes the global variable which brings me step > closer towards composite.c in libcomposite > > Si

[PATCH 1/3] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-28 Thread Sebastian Andrzej Siewior
This patch moves the module options idVendor, idProduct and bcdDevice from composite.c into each gadgets. This ensures compatibility with current gadgets and removes the global variable which brings me step closer towards composite.c in libcomposite Signed-off-by: Sebastian Andrzej Siewior --- d