Re: [PATCH 1/3] udc: net2280: Fix net2280_disable

2019-02-05 Thread Alan Stern
On Tue, 5 Feb 2019 gu...@kiener-muenchen.de wrote: > Zitat von Alan Stern : > > > On Mon, 4 Feb 2019, Guido Kiener wrote: > > > >> From: Guido Kiener > >> > >> A reset e.g. calling ep_reset_338x() can happen while endpoints > >> are enabled. > > > > How can this happen? That routine is called f

Re: [PATCH 1/3] udc: net2280: Fix net2280_disable

2019-02-05 Thread guido
Zitat von Alan Stern : On Mon, 4 Feb 2019, Guido Kiener wrote: From: Guido Kiener A reset e.g. calling ep_reset_338x() can happen while endpoints are enabled. How can this happen? That routine is called from only two places. One is in net2280_disable(), so after the endpoint has already

Re: [PATCH 1/3] udc: net2280: Fix net2280_disable

2019-02-04 Thread Alan Stern
On Mon, 4 Feb 2019, Guido Kiener wrote: > From: Guido Kiener > > A reset e.g. calling ep_reset_338x() can happen while endpoints > are enabled. How can this happen? That routine is called from only two places. One is in net2280_disable(), so after the endpoint has already been disabled. The

[PATCH 1/3] udc: net2280: Fix net2280_disable

2019-02-04 Thread Guido Kiener
From: Guido Kiener A reset e.g. calling ep_reset_338x() can happen while endpoints are enabled. The ep_reset_338x() sets ep->desc = NULL to mark endpoint being invalid. A subsequent call of net2280_disable will fail and return -EINVAL to parent function usb_ep_disable(), which will fail, too, and