Re: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-11 Thread Oliver Neukum
On Mon, 2014-02-10 at 16:54 +0100, Emil Goode wrote: > Since the checks that need to be added in various places are all in > the same subsystem I think it could be done in as little as one patch? Yes, please definitely. Best for bisectability. > If nobody have any objections I will try removing

Re: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-10 Thread Emil Goode
On Mon, Feb 10, 2014 at 02:05:20PM +0100, Bjørn Mork wrote: > Oliver Neukum writes: > > On Mon, 2014-02-10 at 13:00 +0100, Emil Goode wrote: > >> On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote: > > > >> > Well, then how about simply removing the check? > >> > It seems to have outliv

Re: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-10 Thread Bjørn Mork
Oliver Neukum writes: > On Mon, 2014-02-10 at 13:00 +0100, Emil Goode wrote: >> On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote: > >> > Well, then how about simply removing the check? >> > It seems to have outlived its usefulness. >> > >> >Regards >> >Oliver >> > >>

RE: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-10 Thread David Laight
From: Oliver Neukum > . Oh well. But how about merging it with FLAG_MULTI_PACKET? > I really don't want to add more flags. There is a point where enough > flags make absurd having a common code. We are closing in on that point. Any sub-driver that supports multi-packet either has to use stupidly l

Re: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-10 Thread Oliver Neukum
On Mon, 2014-02-10 at 13:00 +0100, Emil Goode wrote: > On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote: > > On Mon, 2014-02-10 at 00:06 +0100, Emil Goode wrote: > > > The AX88772B occasionally send rx packets that cross urb boundaries > > > and the remaining partial packet is sent wit

Re: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-10 Thread Emil Goode
On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote: > On Mon, 2014-02-10 at 00:06 +0100, Emil Goode wrote: > > The AX88772B occasionally send rx packets that cross urb boundaries > > and the remaining partial packet is sent with no hardware header. > > When the buffer with a partial pack

Re: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-09 Thread Oliver Neukum
On Mon, 2014-02-10 at 00:06 +0100, Emil Goode wrote: > The AX88772B occasionally send rx packets that cross urb boundaries > and the remaining partial packet is sent with no hardware header. > When the buffer with a partial packet is of less number of octets > than the value of hard_header_len the

[PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-09 Thread Emil Goode
The AX88772B occasionally send rx packets that cross urb boundaries and the remaining partial packet is sent with no hardware header. When the buffer with a partial packet is of less number of octets than the value of hard_header_len the buffer is discarded by the usbnet module. This is causing dro