[PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic

2018-06-30 Thread Miguel Rodríguez Pérez
There is nothing wrong with it, but there was no way cdc_ncm driver could use it, as it currently overwrites the struct net_device_ops, so the usbnet function set_rx_mode was not ever getting called. This patch restores the right behavior, so that usbnet's set _rx_mode gets called again for cdn_nc

Re: [PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic

2018-06-30 Thread Miguel Rodríguez Pérez
There is nothing wrong with it, but there was no way cdc_ncm driver could use it, as it currently overwrites the struct net_device_ops, so the usbnet function set_rx_mode was not ever getting called. This patch restores the right behavior, so that usbnet's set _rx_mode gets called again for cdn_nc

Re: [PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic

2018-06-29 Thread Oliver Neukum
On Fr, 2018-06-29 at 16:45 +0200, Miguel Rodríguez Pérez wrote: > Subject: [PATCH 1/2] Hook into usbnet_change_mtu respecting usbnet > driver_info > > Change the way cdc_ncm_change_mtu hooks into the netdev_ops > structure so that changes into usbnet driver_info operations > can be respected. Wit

Re: [PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic

2018-06-29 Thread Greg KH
On Fri, Jun 29, 2018 at 04:47:28PM +0200, Miguel Rodríguez Pérez wrote: > Some CDC_NCM devices are used as docks for laptops. In this case, it > makes sense to accept multicast Ethernet traffic, as these devices > can reside in a proper LAN. Without this, mDNS or IPv6 simply do not > work. > > Sig

Re: [PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic

2018-06-29 Thread Miguel Rodríguez Pérez
Some CDC_NCM devices are used as docks for laptops. In this case, it makes sense to accept multicast Ethernet traffic, as these devices can reside in a proper LAN. Without this, mDNS or IPv6 simply do not work. Signed-off-by: Miguel Rodríguez Pérez --- drivers/net/usb/cdc_ncm.c | 28

Re: [PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic

2018-06-29 Thread Miguel Rodríguez Pérez
Subject: [PATCH 1/2] Hook into usbnet_change_mtu respecting usbnet driver_info Change the way cdc_ncm_change_mtu hooks into the netdev_ops structure so that changes into usbnet driver_info operations can be respected. Without this, is was not possible to hook into usbnet_set_rx_mode. Signed-off-b