Re: [PATCH 1/2] USB: hub: fix up early-exit pathway in hub_activate

2016-08-05 Thread Viresh Kumar
On 05-08-16, 11:49, Alan Stern wrote: > The early-exit pathway in hub_activate, added by commit e50293ef9775 > ("USB: fix invalid memory access in hub_activate()") needs > improvement. It duplicates code that is already present at the end of > the subroutine, and it neglects to undo the effect of

[PATCH 1/2] USB: hub: fix up early-exit pathway in hub_activate

2016-08-05 Thread Alan Stern
The early-exit pathway in hub_activate, added by commit e50293ef9775 ("USB: fix invalid memory access in hub_activate()") needs improvement. It duplicates code that is already present at the end of the subroutine, and it neglects to undo the effect of a usb_autopm_get_interface_no_resume() call.