Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-07 Thread Sylwester Nawrocki
On 11/07/2012 02:35 PM, Vivek Gautam wrote: @@ -180,10 +273,12 @@ enum samsung_cpu_type { /* * struct samsung_usbphy - transceiver driver state * @phy: transceiver structure + * @phy3: transceiver structure for USB 3.0 * @plat: platform data * @dev: The parent device supplied t

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-07 Thread Vivek Gautam
Hi, On Wed, Nov 7, 2012 at 5:10 AM, Sylwester Nawrocki wrote: > > Hi, > > I have a few comments. Please see below... > > > On 11/06/2012 04:36 PM, Vivek Gautam wrote: >> >> Adding support for USB3.0 phy for dwc3 controller on >> exynso5250 SOC. > > > exynso -> exynos Sure, will correct this. >

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-06 Thread Sylwester Nawrocki
Hi, I have a few comments. Please see below... On 11/06/2012 04:36 PM, Vivek Gautam wrote: Adding support for USB3.0 phy for dwc3 controller on exynso5250 SOC. exynso -> exynos Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usbphy.c| 337 +++

[PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-06 Thread Vivek Gautam
Adding support for USB3.0 phy for dwc3 controller on exynso5250 SOC. Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usbphy.c| 337 +++ include/linux/usb/samsung_usb_phy.h |1 + 2 files changed, 338 insertions(+), 0 deletions(-) diff --git a/driv