Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread David Eccher
On Fri, Dec 11, 2015 at 9:11 PM, Al Viro wrote: > > On Fri, Dec 11, 2015 at 08:56:26PM +0100, David Eccher wrote: > > Fix bad unlock balance: ep0_write enter with the locks locked from > > inode.c:1769, > > hence it must exit with spinlock held to avoid double unlock in dev_config. > > *Ugh* > >

Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2015 10:56 PM, David Eccher wrote: Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config. Signed-off-by: David Eccher --- drivers/usb/gadget/legacy/inode.c | 1 + 1 file ch

Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread Al Viro
On Fri, Dec 11, 2015 at 08:56:26PM +0100, David Eccher wrote: > Fix bad unlock balance: ep0_write enter with the locks locked from > inode.c:1769, > hence it must exit with spinlock held to avoid double unlock in dev_config. *Ugh* Just take that spinlock before the if (retval < 0) and don't drop

[PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread David Eccher
Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config. Signed-off-by: David Eccher --- drivers/usb/gadget/legacy/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/le