Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

2013-07-11 Thread Sergei Shtylyov
Hello. On 11-07-2013 16:36, Oliver Neukum wrote: I don't think this patch passes checkpatch.pl. This series is a mechanical replacement in dozens of drivers. That mechanicity shows too much in some patches. We cannot demand nice formatting. If you want to do something productive

Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

2013-07-11 Thread Ming Lei
On Thu, Jul 11, 2013 at 8:18 PM, Sergei Shtylyov wrote: > Hello. > > > On 11-07-2013 13:05, Ming Lei wrote: > >> Complete() will be run with interrupt enabled, so change to >> spin_lock_irqsave(). > > >> Cc: Juergen Stuber >> Signed-off-by: Ming Lei >> --- >> drivers/usb/misc/legousbtower.c |

Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

2013-07-11 Thread Oliver Neukum
On Thursday 11 July 2013 16:18:17 Sergei Shtylyov wrote: > I don't think this patch passes checkpatch.pl. This series is a mechanical replacement in dozens of drivers. We cannot demand nice formatting. If you want to do something productive, check the locking in the driver. Regards

Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

2013-07-11 Thread Sergei Shtylyov
Hello. On 11-07-2013 13:05, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Juergen Stuber Signed-off-by: Ming Lei --- drivers/usb/misc/legousbtower.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

2013-07-11 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Juergen Stuber Signed-off-by: Ming Lei --- drivers/usb/misc/legousbtower.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbt