Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-14 Thread Roger Quadros
On 01/11/2013 06:32 PM, Russell King - ARM Linux wrote: > On Fri, Jan 11, 2013 at 06:03:21PM +0200, Roger Quadros wrote: >> diff --git a/include/linux/platform_data/usb-omap.h >> b/include/linux/platform_data/usb-omap.h >> index d63eb7d..927b8a1 100644 >> --- a/include/linux/platform_data/usb-omap.

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-11 Thread Alan Stern
On Fri, 11 Jan 2013, Roger Quadros wrote: > Apart from what you mentioned I did some more trivial changes. e.g. > > + !IS_ENABLED(CONFIG_USB_EHCI_HCD_OMAP) && \ > instead of > + !defined(CONFIG_USB_EHCI_HCD_OMAP) && \ Ah, that's a very good catch. There's another entry needing the sam

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-11 Thread Russell King - ARM Linux
On Fri, Jan 11, 2013 at 06:03:21PM +0200, Roger Quadros wrote: > diff --git a/include/linux/platform_data/usb-omap.h > b/include/linux/platform_data/usb-omap.h > index d63eb7d..927b8a1 100644 > --- a/include/linux/platform_data/usb-omap.h > +++ b/include/linux/platform_data/usb-omap.h > @@ -38,6 +3

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-11 Thread Roger Quadros
On 01/11/2013 05:28 PM, Alan Stern wrote: > On Fri, 11 Jan 2013, Roger Quadros wrote: > >> Alan, >> >> Thanks for the patch. I've pasted the version that builds and works and >> put you as the Author of the patch, hope it is fine. > > As far as I can see, yours is the same as what I posted except

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-11 Thread Alan Stern
On Fri, 11 Jan 2013, Roger Quadros wrote: > Alan, > > Thanks for the patch. I've pasted the version that builds and works and > put you as the Author of the patch, hope it is fine. As far as I can see, yours is the same as what I posted except that: You altered the changes to ehci-hcd.c

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-11 Thread Roger Quadros
On 01/11/2013 12:59 PM, Roger Quadros wrote: > On 01/10/2013 10:48 PM, Alan Stern wrote: >> On Thu, 10 Jan 2013, Roger Quadros wrote: >> >>> If the OMAP's Host controller is in PHY mode then we instantiate >>> a platform device for the PHY (one for each port in PHY mode) and >>> hold a reference to

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-11 Thread Roger Quadros
On 01/10/2013 10:48 PM, Alan Stern wrote: > On Thu, 10 Jan 2013, Roger Quadros wrote: > >> If the OMAP's Host controller is in PHY mode then we instantiate >> a platform device for the PHY (one for each port in PHY mode) and >> hold a reference to it so that we can use the usb_phy API, e.g. >> whi

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Roger Quadros wrote: > If the OMAP's Host controller is in PHY mode then we instantiate > a platform device for the PHY (one for each port in PHY mode) and > hold a reference to it so that we can use the usb_phy API, e.g. > while suspend/resume. > > The platform data for the

[PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-10 Thread Roger Quadros
If the OMAP's Host controller is in PHY mode then we instantiate a platform device for the PHY (one for each port in PHY mode) and hold a reference to it so that we can use the usb_phy API, e.g. while suspend/resume. The platform data for the PHY must be supplied in the newly added .phy_config par