Re: [PATCH 04/16] mfd: omap-usb-tll: Move port clock handling out of runtime ops

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 02:45:46PM +0200, Roger Quadros wrote: > >>spin_unlock_irqrestore(&tll->lock, flags); > >> > >> - return 0; > >> + return i; > >> } > >> +EXPORT_SYMBOL_GPL(omap_tll_enable); > >> > >> -static int usbtll_runtime_suspend(struct device *dev) > >> +int omap_tll_d

Re: [PATCH 04/16] mfd: omap-usb-tll: Move port clock handling out of runtime ops

2012-11-21 Thread Roger Quadros
On 11/21/2012 02:06 PM, Felipe Balbi wrote: > On Thu, Nov 15, 2012 at 04:34:02PM +0200, Roger Quadros wrote: >> The port clocks are not required to access the port registers, >> they are only needed when the PORT is used. So we move the port clock >> handling code to omap_tll_enable/disable(). >> >

Re: [PATCH 04/16] mfd: omap-usb-tll: Move port clock handling out of runtime ops

2012-11-21 Thread Felipe Balbi
On Thu, Nov 15, 2012 at 04:34:02PM +0200, Roger Quadros wrote: > The port clocks are not required to access the port registers, > they are only needed when the PORT is used. So we move the port clock > handling code to omap_tll_enable/disable(). > > Also get of unnecessary spinlock code in probe f

[PATCH 04/16] mfd: omap-usb-tll: Move port clock handling out of runtime ops

2012-11-15 Thread Roger Quadros
The port clocks are not required to access the port registers, they are only needed when the PORT is used. So we move the port clock handling code to omap_tll_enable/disable(). Also get of unnecessary spinlock code in probe function and check for missing platform data. Signed-off-by: Roger Quadro