Re: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-27 Thread Felipe Balbi
Hi, On Wed, Feb 26, 2014 at 11:00:33PM +, Paul Zimmerman wrote: > Hi Felipe, > > Can you drop the part that checks the DCNRD bit, please? I made a > mistake when I originally submitted this. It is not necessary to check > the DCNRD bit every time before reading the link state, it should only

RE: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-26 Thread Paul Zimmerman
11:41 AM To: Linux USB Mailing List Cc: Paul Zimmerman; Paul Zimmerman; Felipe Balbi Subject: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state From: Paul Zimmerman This function will be used during hibernation to get the current link state. It will be needed at least for

Re: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-26 Thread Felipe Balbi
Hi, On Wed, Feb 26, 2014 at 03:34:43PM +0530, Pratyush Anand wrote: > On Wed, Feb 26, 2014 at 03:40:36AM +0800, Felipe Balbi wrote: > > From: Paul Zimmerman > > > > This function will be used during hibernation to get > > the current link state. It will be needed at least > > for Hibernation sup

Re: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-26 Thread Pratyush Anand
On Wed, Feb 26, 2014 at 03:40:36AM +0800, Felipe Balbi wrote: > From: Paul Zimmerman > > This function will be used during hibernation to get > the current link state. It will be needed at least > for Hibernation support. > Since we do receive linksts_change_interrupt, where we already update d

Re: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-25 Thread Felipe Balbi
On Wed, Feb 26, 2014 at 12:10:09AM +0300, Sergei Shtylyov wrote: > Hello. > > On 02/25/2014 10:40 PM, Felipe Balbi wrote: > > >From: Paul Zimmerman > > >This function will be used during hibernation to get > >the current link state. It will be needed at least > >for Hibernation support. > > >S

Re: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-25 Thread Sergei Shtylyov
Hello. On 02/25/2014 10:40 PM, Felipe Balbi wrote: From: Paul Zimmerman This function will be used during hibernation to get the current link state. It will be needed at least for Hibernation support. Signed-off-by: Paul Zimmerman Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadg

[PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-25 Thread Felipe Balbi
From: Paul Zimmerman This function will be used during hibernation to get the current link state. It will be needed at least for Hibernation support. Signed-off-by: Paul Zimmerman Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 36 drivers/usb/