On Fri, Oct 09, 2015 at 04:19:57PM -0500, Felipe Balbi wrote:
> > Signed-off-by: Christoph Hellwig
> > Reviewed-by: Andrzej Pietrasiewicz
>
> I suppose this depends on other fs/configfs changes ?
The whole series should be applied in order, but doesn't have any
other dependencies.
--
To unsubsc
Hi,
Christoph Hellwig writes:
> To simplify the configfs interface and remove boilerplate code that also
> causes binary bloat.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Andrzej Pietrasiewicz
I suppose this depends on other fs/configfs changes ?
--
balbi
signature.asc
Descriptio
To simplify the configfs interface and remove boilerplate code that also
causes binary bloat.
Signed-off-by: Christoph Hellwig
Reviewed-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/configfs.c | 295 ++--
include/linux/usb/gadget_configfs.h | 19 +--
2
Hi,
On Mon, Sep 28, 2015 at 03:33:28PM +0200, Christoph Hellwig wrote:
> The Subject line is part of the commit log. If you have a useful
heh
> suggestion for improving the logs please feel free to suggest it.
how about explaining why you want per-attribute show/store methods ?
--
balbi
si
On Wed, Sep 30, 2015 at 11:43:01AM -0500, Felipe Balbi wrote:
> Seems like there are *ton* of uses of container_of() wrapped within a simple
> macro. What convention are you talking about, again ?
The convention of using inline functions over macros when possible.
We don't do that all the time but
On Wed, Sep 30, 2015 at 12:35:38PM -0400, Tejun Heo wrote:
> On Wed, Sep 30, 2015 at 11:32:19AM -0500, Felipe Balbi wrote:
> > On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote:
> > > On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote:
> > > > On Mon, Sep 28, 2015 at 03:35:14PM +0
On Wed, Sep 30, 2015 at 11:32:19AM -0500, Felipe Balbi wrote:
> On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote:
> > On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote:
> > > On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote:
> > > > On Sun, Sep 27, 2015 at 10:50
On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote:
> On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote:
> > On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote:
> > > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote:
> > > > this (and the other helper be
On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote:
> On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote:
> > this (and the other helper below) could be macros just fine.
>
> They could, but they shouldn't. Inlines are always preferable over
> function-like macros.
says
On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote:
> On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote:
> > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote:
> > > this (and the other helper below) could be macros just fine.
> >
> > They could, but they shoul
On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote:
> this (and the other helper below) could be macros just fine.
They could, but they shouldn't. Inlines are always preferable over
function-like macros.
> Are you 100% compiler
> will *always* inline these helpers.
With gcc you can't
The Subject line is part of the commit log. If you have a useful
suggestion for improving the logs please feel free to suggest it.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kerne
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze:
Signed-off-by: Christoph Hellwig
Reviewed-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/configfs.c | 295 ++--
include/linux/usb/gadget_configfs.h | 19 +--
2 files changed, 118 insertions(+),
On Fri, Sep 25, 2015 at 06:49:39AM -0700, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
> drivers/usb/gadget/configfs.c | 295
> ++--
> include/linux/usb/gadget_configfs.h | 19 +--
> 2 files changed, 118 insertions(+), 196 deletions(-)
On Fri, Sep 25, 2015 at 06:49:39AM -0700, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
I need commit logs for everything. Without commit logs, I can't apply your
patches.
--
balbi
signature.asc
Description: PGP signature
Signed-off-by: Christoph Hellwig
---
drivers/usb/gadget/configfs.c | 295 ++--
include/linux/usb/gadget_configfs.h | 19 +--
2 files changed, 118 insertions(+), 196 deletions(-)
diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
inde
16 matches
Mail list logo
