RE: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Sharma, Sanjeev
: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held() Hi, On 09/10/2014 04:38 PM, Peter Hurley wrote: > [ +cc Peter Zijlstra, Ingo Molnar ] > > On 09/10/2014 07:46 AM, Hans de Goede wrote: >> From: Sanjeev Sharma >> >> On some architecture spin_is_l

RE: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Sharma, Sanjeev
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Wednesday, September 10, 2014 7:21 PM To: Hans de Goede Cc: Oliver Neukum; linux-usb@vger.kernel.org; linux-s...@vger.kernel.org; sta...@vger.kernel.org; Sharma, Sanjeev Subject: Re: [PATCH 01/21] uas

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Hans de Goede
Hi, On 09/10/2014 04:38 PM, Peter Hurley wrote: > [ +cc Peter Zijlstra, Ingo Molnar ] > > On 09/10/2014 07:46 AM, Hans de Goede wrote: >> From: Sanjeev Sharma >> >> On some architecture spin_is_locked() always return false in >> uniprocessor configuration and therefore it would be advise to repl

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Peter Hurley
[ +cc Peter Zijlstra, Ingo Molnar ] On 09/10/2014 07:46 AM, Hans de Goede wrote: > From: Sanjeev Sharma > > On some architecture spin_is_locked() always return false in > uniprocessor configuration and therefore it would be advise to replace > with lockdep_assert_held(). > > Signed-off-by: Sanj

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Greg Kroah-Hartman
On Wed, Sep 10, 2014 at 03:15:41PM +0200, Hans de Goede wrote: > Hi, > > On 09/10/2014 02:54 PM, Oliver Neukum wrote: > > On Wed, 2014-09-10 at 14:00 +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 09/10/2014 01:56 PM, Oliver Neukum wrote: > >>> On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede w

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Hans de Goede
Hi, On 09/10/2014 02:54 PM, Oliver Neukum wrote: > On Wed, 2014-09-10 at 14:00 +0200, Hans de Goede wrote: >> Hi, >> >> On 09/10/2014 01:56 PM, Oliver Neukum wrote: >>> On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede wrote: Hi, Note this series is NOT intended for stable, but I acc

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Oliver Neukum
On Wed, 2014-09-10 at 14:00 +0200, Hans de Goede wrote: > Hi, > > On 09/10/2014 01:56 PM, Oliver Neukum wrote: > > On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede wrote: > >> Hi, > >> > >> Note this series is NOT intended for stable, but I accidentally > >> had "cc = sta...@vger.kernel.org" in my

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Hans de Goede
Hi, On 09/10/2014 01:56 PM, Oliver Neukum wrote: > On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede wrote: >> Hi, >> >> Note this series is NOT intended for stable, but I accidentally >> had "cc = sta...@vger.kernel.org" in my .git/config when sending >> this series, please ignore for stable. >> >

RE: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Sharma, Sanjeev
-Original Message- From: Oliver Neukum [mailto:oneu...@suse.de] Sent: Wednesday, September 10, 2014 5:26 PM To: Hans de Goede Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-s...@vger.kernel.org; sta...@vger.kernel.org; Sharma, Sanjeev Subject: Re: [PATCH 01/21] uas: replace

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Oliver Neukum
On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede wrote: > Hi, > > Note this series is NOT intended for stable, but I accidentally > had "cc = sta...@vger.kernel.org" in my .git/config when sending > this series, please ignore for stable. > > NACK for stable. If this is not for stable, what do yo

Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Hans de Goede
Hi, Note this series is NOT intended for stable, but I accidentally had "cc = sta...@vger.kernel.org" in my .git/config when sending this series, please ignore for stable. NACK for stable. Sorry & Regards, Hans On 09/10/2014 01:46 PM, Hans de Goede wrote: > From: Sanjeev Sharma > > On some

[PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-10 Thread Hans de Goede
From: Sanjeev Sharma On some architecture spin_is_locked() always return false in uniprocessor configuration and therefore it would be advise to replace with lockdep_assert_held(). Signed-off-by: Sanjeev Sharma Signed-off-by: Hans de Goede --- drivers/usb/storage/uas.c | 8 1 file ch