Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Greg KH
On Mon, Sep 23, 2013 at 05:23:07PM -0700, Sarah Sharp wrote: > On Mon, Sep 23, 2013 at 02:49:07PM -0700, Greg KH wrote: > > On Mon, Sep 23, 2013 at 04:38:22PM -0500, Bjorn Helgaas wrote: > > > On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > > > > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia R

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Sarah Sharp
On Mon, Sep 23, 2013 at 02:49:07PM -0700, Greg KH wrote: > On Mon, Sep 23, 2013 at 04:38:22PM -0500, Bjorn Helgaas wrote: > > On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > > > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: > > >> I had in mind that the pci_ops .read and .wri

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Greg KH
On Mon, Sep 23, 2013 at 04:38:22PM -0500, Bjorn Helgaas wrote: > On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: > >> On 09/23/2013 07:45 PM, Sarah Sharp wrote: > >> >On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wr

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Bjorn Helgaas
On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: >> On 09/23/2013 07:45 PM, Sarah Sharp wrote: >> >On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: >> >>The function pci_write_config_dword() sets the appropriate by

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Greg KH
On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: > On 09/23/2013 07:45 PM, Sarah Sharp wrote: > >On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: > >>The function pci_write_config_dword() sets the appropriate byteordering > >>internally so the value argument should

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Xenia Ragiadakou
On 09/23/2013 07:45 PM, Sarah Sharp wrote: On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: The function pci_write_config_dword() sets the appropriate byteordering internally so the value argument should not be converted to little-endian. This bug was found by sparse. Can you g

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Sarah Sharp
On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: > The function pci_write_config_dword() sets the appropriate byteordering > internally so the value argument should not be converted to little-endian. > This bug was found by sparse. Can you give the exact error or warning message t

[PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-20 Thread Xenia Ragiadakou
The function pci_write_config_dword() sets the appropriate byteordering internally so the value argument should not be converted to little-endian. This bug was found by sparse. Signed-off-by: Xenia Ragiadakou --- drivers/usb/host/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion