Re: [PATCH] xhci: fix list access before init

2013-04-08 Thread Aguirre Rodriguez, Sergio A
On Mon, Apr 08, 2013 at 03:53:19PM -0700, Sarah Sharp wrote: > On Thu, Apr 04, 2013 at 08:31:26PM +0400, Vladimir Murzin wrote: > > Commits > > 9574323 xHCI: test USB2 software LPM > > b92cc66 xHCI: add aborting command ring function > > introduce useful functions which involves lists manip

Re: [PATCH] xhci: fix list access before init

2013-04-08 Thread Sarah Sharp
On Thu, Apr 04, 2013 at 08:31:26PM +0400, Vladimir Murzin wrote: > Commits > 9574323 xHCI: test USB2 software LPM > b92cc66 xHCI: add aborting command ring function > introduce useful functions which involves lists manipulations. > > If for whatever reason we fall into fail path in xhc

Re: [PATCH] xhci: fix list access before init

2013-04-08 Thread Greg KH
On Mon, Apr 08, 2013 at 08:18:44AM -0700, Sarah Sharp wrote: > On Fri, Apr 05, 2013 at 08:52:53AM -0700, Aguirre Rodriguez, Sergio A wrote: > > On Fri, Apr 05, 2013 at 06:51:21AM +0400, Vladimir Murzin wrote: > > > On Thu, Apr 04, 2013 at 12:29:25PM -0700, Sarah Sharp wrote: > > > What about pickin

Re: [PATCH] xhci: fix list access before init

2013-04-08 Thread Sarah Sharp
On Fri, Apr 05, 2013 at 08:52:53AM -0700, Aguirre Rodriguez, Sergio A wrote: > On Fri, Apr 05, 2013 at 06:51:21AM +0400, Vladimir Murzin wrote: > > On Thu, Apr 04, 2013 at 12:29:25PM -0700, Sarah Sharp wrote: > > What about picking up Sergio's patch and bw table part of this patch > > as separate c

Re: [PATCH] xhci: fix list access before init

2013-04-05 Thread Aguirre Rodriguez, Sergio A
On Fri, Apr 05, 2013 at 06:51:21AM +0400, Vladimir Murzin wrote: > On Thu, Apr 04, 2013 at 12:29:25PM -0700, Sarah Sharp wrote: > > Someone else is already working on a patch to fix part of this: > > > > http://marc.info/?l=linux-usb&m=136509667003716&w=2 > > > > Please coordinate with them. > >

Re: [PATCH] xhci: fix list access before init

2013-04-04 Thread Vladimir Murzin
On Thu, Apr 04, 2013 at 12:29:25PM -0700, Sarah Sharp wrote: > Someone else is already working on a patch to fix part of this: > > http://marc.info/?l=linux-usb&m=136509667003716&w=2 > > Please coordinate with them. > > Also, two people trying to solve the same simple bug and using almost > exac

RE: [PATCH] xhci: fix list access before init

2013-04-04 Thread Aguirre Rodriguez, Sergio A
> -Original Message- > From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > Sent: Thursday, April 04, 2013 12:29 PM > To: Vladimir Murzin > Cc: linux-usb@vger.kernel.org; gre...@suse.de; dse...@gmail.com; Aguirre > Rodriguez, Sergio A > Subject: Re: [PATCH]

Re: [PATCH] xhci: fix list access before init

2013-04-04 Thread Sarah Sharp
Someone else is already working on a patch to fix part of this: http://marc.info/?l=linux-usb&m=136509667003716&w=2 Please coordinate with them. Also, two people trying to solve the same simple bug and using almost exactly the same commit messages seems like too much of a coincidence. Are you wo

[PATCH] xhci: fix list access before init

2013-04-04 Thread Vladimir Murzin
Commits 9574323 xHCI: test USB2 software LPM b92cc66 xHCI: add aborting command ring function introduce useful functions which involves lists manipulations. If for whatever reason we fall into fail path in xhci_mem_init() we may access the lists in xhci_mem_cleanup() before they ge