Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-10-25 Thread Joel Stanley
On Tue, Sep 20, 2016 at 5:56 PM, Mathias Nyman wrote: > Quick Googling shows that that TI TUSB 73x0 USB3.0 xHCI host has an issue > with halting. > > Errata says host needs 125us to 1ms between the last control transfer and > clearing the run/stop bit. (halting the host) > > Suggested workaround i

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-20 Thread Mathias Nyman
On 19.09.2016 11:23, Joel Stanley wrote: Hi Mathias, On Mon, Sep 19, 2016 at 4:33 PM, Greg KH wrote: On Mon, Sep 19, 2016 at 04:05:45PM +0930, Joel Stanley wrote: We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the p

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Sergei Shtylyov
Hello. On 9/19/2016 9:35 AM, Joel Stanley wrote: We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while n

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Joel Stanley
Hi Mathias, On Mon, Sep 19, 2016 at 4:33 PM, Greg KH wrote: > On Mon, Sep 19, 2016 at 04:05:45PM +0930, Joel Stanley wrote: >> We can't halt the secondary HCD, because it's also the primary HCD, >> which will cause problems if we have devices attached to the primary >> HCD, like a keyboard. >> >>

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Mathias Nyman
On 19.09.2016 09:35, Joel Stanley wrote: We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while now. The ma

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Greg KH
On Mon, Sep 19, 2016 at 04:05:45PM +0930, Joel Stanley wrote: > We can't halt the secondary HCD, because it's also the primary HCD, > which will cause problems if we have devices attached to the primary > HCD, like a keyboard. > > We've been carrying this in our Linux-as-a-bootloader environment f

[RFC PATCH] xhci: do not halt the secondary HCD

2016-09-18 Thread Joel Stanley
We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while now. The machines all have the same TI TUSB73x0 part,

Re: [PATCH] xhci: do not halt the secondary HCD

2014-03-14 Thread Thadeu Lima de Souza Cascardo
On Sat, Mar 15, 2014 at 08:31:29AM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2014-03-14 at 18:16 -0300, Thadeu Lima de Souza Cascardo wrote: > > What seems to happen for the TI chip is that while the HID device is > > still connected (ie, we still have pending URBs on the queue), halting > > i

Re: [PATCH] xhci: do not halt the secondary HCD

2014-03-14 Thread Benjamin Herrenschmidt
On Fri, 2014-03-14 at 18:16 -0300, Thadeu Lima de Souza Cascardo wrote: > What seems to happen for the TI chip is that while the HID device is > still connected (ie, we still have pending URBs on the queue), halting > is not a great idea. And as described above, what is done right now > is: Can yo

[PATCH] xhci: do not halt the secondary HCD

2014-03-14 Thread Thadeu Lima de Souza Cascardo
We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. --- Not yet signed-off because I am waiting for some kexec testing to be done on another environment, and I would like to bring this into a