Re: [PATCH] xhci: Make handover code more robust

2012-09-05 Thread Sarah Sharp
On Wed, Sep 05, 2012 at 02:21:52PM +0100, Matthew Garrett wrote: > On Tue, Sep 04, 2012 at 03:40:56PM -0700, Sarah Sharp wrote: > > On Tue, Aug 14, 2012 at 04:44:49PM -0400, Matthew Garrett wrote: > > > I've no idea what's causing the underlying problem, and xhci still doesn't > > > actually *work*

Re: [PATCH] xhci: Make handover code more robust

2012-09-05 Thread Matthew Garrett
On Wed, Sep 05, 2012 at 02:21:52PM +0100, Matthew Garrett wrote: > It's an SNB-E board with a series 7 chipset. The xHCI controller is an > NEC. When it's in this failure state it doesn't seem like there's > anything in the mmio BAR that's happy to talk to us, but I'll check the > logs to see w

Re: [PATCH] xhci: Make handover code more robust

2012-09-05 Thread Matthew Garrett
On Tue, Sep 04, 2012 at 03:40:56PM -0700, Sarah Sharp wrote: > On Tue, Aug 14, 2012 at 04:44:49PM -0400, Matthew Garrett wrote: > > I've no idea what's causing the underlying problem, and xhci still doesn't > > actually *work* even with this, but the machine at least boots which will > > probably m

Re: [PATCH] xhci: Make handover code more robust

2012-09-04 Thread Sarah Sharp
On Tue, Aug 14, 2012 at 04:44:49PM -0400, Matthew Garrett wrote: > My test platform (Intel DX79SI) boots reliably under BIOS, but frequently > crashes when booting via UEFI. I finally tracked this down to the xhci > handoff code. It seems that reads from the device occasionally just return > 0xff,

Re: [PATCH] xhci: Make handover code more robust

2012-08-20 Thread Greg KH
On Mon, Aug 20, 2012 at 08:36:56PM +0100, Matthew Garrett wrote: > Anyone want to take this? Sarah is on vacation until the end of this week, so I'd wait until then to worry about it being lost. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mes

Re: [PATCH] xhci: Make handover code more robust

2012-08-20 Thread Matthew Garrett
Anyone want to take this? -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xhci: Make handover code more robust

2012-08-14 Thread Matthew Garrett
On Tue, Aug 14, 2012 at 10:57:58PM +0200, Peter Stuge wrote: > Matthew Garrett wrote: > > +++ b/drivers/usb/host/pci-quirks.c > .. > > @@ -830,9 +830,17 @@ static void __devinit quirk_usb_handoff_xhci(struct > > pci_dev *pdev) > > */ > > ext_cap_offset = xhci_find_next_cap_offset(base, >

Re: [PATCH] xhci: Make handover code more robust

2012-08-14 Thread Peter Stuge
Matthew Garrett wrote: > +++ b/drivers/usb/host/pci-quirks.c .. > @@ -830,9 +830,17 @@ static void __devinit quirk_usb_handoff_xhci(struct > pci_dev *pdev) >*/ > ext_cap_offset = xhci_find_next_cap_offset(base, > XHCI_HCC_PARAMS_OFFSET); > do { > + if ((ext_cap_off

[PATCH] xhci: Make handover code more robust

2012-08-14 Thread Matthew Garrett
My test platform (Intel DX79SI) boots reliably under BIOS, but frequently crashes when booting via UEFI. I finally tracked this down to the xhci handoff code. It seems that reads from the device occasionally just return 0xff, resulting in xhci_find_next_cap_offset generating a value that's larger t