Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 08:48:19AM +0200, Oliver Neukum wrote: > On Thu, 2014-07-17 at 17:13 -0700, Greg KH wrote: > > On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote: > > > > I see no sane way to come up with numbers. > > > Unless you want to measure the time between spurious event.

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-18 Thread Oliver Neukum
On Thu, 2014-07-17 at 17:13 -0700, Greg KH wrote: > On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote: > > I see no sane way to come up with numbers. > > Unless you want to measure the time between spurious event. > > But that would really be overkill. I'd rather fix a concrete > > iss

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-17 Thread Greg KH
On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote: > On Mon, 2014-07-14 at 11:04 -0400, Alan Stern wrote: > > On Mon, 14 Jul 2014, Oliver Neukum wrote: > > > > > On Mon, 2014-07-14 at 07:50 -0700, Greg KH wrote: > > > > > > > So if I have hubs with the same "broken" port, I'll only ge

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-14 Thread Oliver Neukum
On Mon, 2014-07-14 at 11:04 -0400, Alan Stern wrote: > On Mon, 14 Jul 2014, Oliver Neukum wrote: > > > On Mon, 2014-07-14 at 07:50 -0700, Greg KH wrote: > > > > > So if I have hubs with the same "broken" port, I'll only get one > > > message? What if I have 2 "broken" ports, I'll keep getting th

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-14 Thread Alan Stern
On Mon, 14 Jul 2014, Oliver Neukum wrote: > On Mon, 2014-07-14 at 07:50 -0700, Greg KH wrote: > > > So if I have hubs with the same "broken" port, I'll only get one > > message? What if I have 2 "broken" ports, I'll keep getting the > > messages? > > Well, hubs are not a problem. > > > I'm not

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-14 Thread Oliver Neukum
On Mon, 2014-07-14 at 07:50 -0700, Greg KH wrote: > So if I have hubs with the same "broken" port, I'll only get one > message? What if I have 2 "broken" ports, I'll keep getting the > messages? Well, hubs are not a problem. > I'm not suggesting that we have a "broken port" flag per port for ea

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-14 Thread Greg KH
On Mon, Jul 14, 2014 at 03:39:49PM +0200, oneu...@suse.de wrote: > From: Oliver Neukum > > Some laptops have an internal port for a BT device which picks > up noise when the kill switch is used, but not enough to trigger > printk_rlimit(). So we shouldn't log consecutive faults of this kind. > >

[PATCH] usbcore: don't log on consecutive debounce failures of the same port

2014-07-14 Thread oneukum
From: Oliver Neukum Some laptops have an internal port for a BT device which picks up noise when the kill switch is used, but not enough to trigger printk_rlimit(). So we shouldn't log consecutive faults of this kind. Signed-off-by: Oliver Neukum --- drivers/usb/core/hub.c | 11 --- 1