Hi Greg,
There was problem with my email client.
Hope now it is fine.
---
[PATCH 1/3] usb: storage: Proper cmd result assignment
This change replaces DID_ABORT with DID_TIMEOUT as a command result
whenever US_FLIDX_TIMED_OUT bit is set.
This change is made to bring USB storage inline with a rec
On Tue, Dec 10, 2013 at 10:53:59AM +0530, Vishal Annapurve wrote:
> Hi Greg,
>
> Does this look fine? I will send over other patches
> once you confirm.
I'm not going to confirm a broken format...
Please go read the file I pointed you at as to how to properly do
this.
greg k-h
--
To unsubscribe
Hi Greg,
Does this look fine? I will send over other patches
once you confirm.
Patch set 1:
-
[PATCH 1/3] usb: storage: Proper cmd result assignment
This change replaces DID_ABORT with DID_TIMEOUT as a command result
whenever US_FLIDX_TIMED_OUT bit is set.
This change is made to bring
On Mon, Dec 09, 2013 at 03:14:07PM +0530, Vishal Annapurve wrote:
> Hi Greg,
>
> Attached are the patches.
As Oliver said, I can't take these, please read
Documentation/SubmittingPatches for how to do this properly.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe l
On Mon, 2013-12-09 at 15:14 +0530, Vishal Annapurve wrote:
> Hi Greg,
>
> Attached are the patches.
Hi,
please send patches in the clear, inline, one patch per mail
and with a "Signed-off-by" line, as described in the Documentation
directory of the kernel.
Regards
Oliver
Hi Greg,
Attached are the patches.
Regards,
Vishal
On Monday 09 December 2013 07:29 AM, Greg KH wrote:
On Sat, Nov 16, 2013 at 12:23:50PM +0530, Vishal Annapurve wrote:
Hi,
Here are the updated patches:
Can you please resend these in a format which I can apply them in
without having to h
On Sat, Nov 16, 2013 at 12:23:50PM +0530, Vishal Annapurve wrote:
> Hi,
>
> Here are the updated patches:
Can you please resend these in a format which I can apply them in
without having to hand-edit all three of them?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscri
On Sat, 16 Nov 2013, Vishal Annapurve wrote:
> Hi,
>
> Here are the updated patches:
>
> [PATCH 1/3] usb: storage: Proper cmd result assignment
>
> This change replaces DID_ABORT with DID_TIMEOUT as a command result
> whenever US_FLIDX_TIMED_OUT bit is set.
>
> This change is made to bring US
'Ming Lei'; 'Linux Kernel Mailing List'; 'linux-usb'
Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result
Hi,
[PATCH 2/3] keucr: Proper cmd result assignment
This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever
US_FLIDX_TIM
} else {
SkipForAbort:
--
1.8.4.2
Regards,
Vishal
-Original Message-
From: Vishal Annapurve
Sent: Saturday, November 16, 2013 12:24 PM
To: 'Alan Stern'
Cc: Ming Lei; Linux Kernel Mailing List; linux-usb
Subject: RE: [PATCH] usb-storage: scsiglue: C
he command had
* already completed with a different result code. */
if (test_bit(US_FLIDX_TIMED_OUT, &us->dflags)) {
complete(&(us->notify));
--
1.8.4.2
Regards,
Vishal
-Original Message-
From: Alan Stern [mailt
On Sat, 26 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> Here is the new patch:
>
> From: Vishal Annapurve
> Date: Sat, 26 Oct 2013 21:10:11 +0530
> Subject: [PATCH] usb: storage: Proper cmd result assignment
>
> This change replaces DID_ABORT with DID_TIMEOUT as a command result
> whenever
On Sat, 26 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> Here is the new patch:
>
> From: Vishal Annapurve
> Date: Sat, 26 Oct 2013 21:10:11 +0530
> Subject: [PATCH] usb: storage: Proper cmd result assignment
>
> This change replaces DID_ABORT with DID_TIMEOUT as a command result
> whenever
T flag, not srb->result == DID_ABORT, because
+* the TIMED_OUT flag, not srb->result == DID_TIME_OUT, because
* the timeout might have occurred after the command had
* already completed with a different result code. */
if (test_b
On Sat, 19 Oct 2013, Vishal Annapurve wrote:
> Hi,
>
> Attaching the new patch which will replace all the occurrences of DID_ABORT
> with DID_TIMOUT in USB Storage whenever it sees US_FLIDX_TIMED_OUT bit
> is set.
It seems okay, but you forgot to update the isd200.c and
cypress_atacb.c files.
A
To: Vishal Annapurve
Cc: Ming Lei; Linux Kernel Mailing List; linux-usb
Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result
On Fri, 18 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> What I wanted to say was If the bit US_FLIDX_TIMED_OUT can have more
> meaning
On Fri, 18 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> What I wanted to say was If the bit US_FLIDX_TIMED_OUT can have more
> meanings than timed out then maybe it would be best to override the
> results after usb-storage is done with the command maybe in scsi layer
> itself who aborted it i
?
Regards,
Vishal
-Original Message-
From: Alan Stern [mailto:st...@rowland.harvard.edu]
Sent: Tuesday, October 15, 2013 10:22 PM
To: Vishal Annapurve
Cc: Ming Lei; Linux Kernel Mailing List; linux-usb
Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result
On Tue, 15 Oct 2013
On Wed, 16 Oct 2013, Ming Lei wrote:
> > Of course the SCSI midlayer has decided to abort. That's the only way
> > this bit can get set. But usb-storage doesn't know why SCSI decided to
> > abort.
>
> usb-storage may know if it is caused by timeout via .eh_timed_out callback
> if it wants to kn
On Wed, Oct 16, 2013 at 4:22 AM, Alan Stern wrote:
> On Tue, 15 Oct 2013, Vishal Annapurve wrote:
>
>> Hi Alan,
>>
>> USB storage maybe just has to say that the abort occurred. By setting the
>> US_FLIDX_TIMED_OUT bit USB storage is getting signaled that the reason was
>> time out and the command
On Tue, 15 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> USB storage maybe just has to say that the abort occurred. By setting the
> US_FLIDX_TIMED_OUT bit USB storage is getting signaled that the reason was
> time out and the command is being aborted.
No. By setting the US_FLIDX_TIMED_OUT b
ernel Mailing List; linux-usb
Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result
On Tue, 15 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> This issue seems more related to the devices using SCSI protocol and
> the changes otherwise will be at more places giving th
On Tue, 15 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> This issue seems more related to the devices using SCSI protocol and the
> changes otherwise will be at more places giving the same end result.
>
> I think as the comment says over the command_abort function,
> intentional result change
-Original Message-
From: Alan Stern [mailto:st...@rowland.harvard.edu]
Sent: Tuesday, October 15, 2013 5:55 PM
To: Ming Lei
Cc: Vishal Annapurve; Linux Kernel Mailing List; linux-usb
Subject: Re: [PATCH] usb-storage: scsiglue: Changing the command result
On Tue, 15 Oct 2013, Ming Lei wrote
On Tue, 15 Oct 2013, Ming Lei wrote:
> On Thu, Sep 26, 2013 at 7:35 PM, Vishal Annapurve
> wrote:
> > Hi,
> >
> > There was a recent commit in mainline for the scsi devices which do not
> > respond properly to medium access command:
> >
> > commit18a4d0a22ed6c54b67af7718c305cd010f09ddf8
> >
On Thu, Sep 26, 2013 at 7:35 PM, Vishal Annapurve wrote:
> Hi,
>
> There was a recent commit in mainline for the scsi devices which do not
> respond properly to medium access command:
>
> commit18a4d0a22ed6c54b67af7718c305cd010f09ddf8
>
> [SCSI] Handle disk devices which can not process medium
26 matches
Mail list logo
