Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Greg KH
On Thu, Jul 24, 2014 at 12:20:37PM -0400, Sasha Levin wrote: > On 07/24/2014 12:04 PM, Greg KH wrote: > >> If you add a revert and leave the original broken commit in, wouldn't it > >> cause issues > >> > for anyone trying to bisect a build breakage? > > Yes it does. > > > > I can not rebase my p

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Sasha Levin
On 07/24/2014 12:04 PM, Greg KH wrote: >> If you add a revert and leave the original broken commit in, wouldn't it >> cause issues >> > for anyone trying to bisect a build breakage? > Yes it does. > > I can not rebase my public trees, nor should any other kernel > maintainer. This has been true

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Greg KH
On Thu, Jul 24, 2014 at 09:14:49AM -0400, Sasha Levin wrote: > On 07/23/2014 12:49 PM, Greg KH wrote: > > On Wed, Jul 23, 2014 at 08:56:10AM -0400, Sasha Levin wrote: > >> > Revert since the commit message is incorrect and the original author > >> > refuses > >> > to fix/maintain it because "it's

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Sasha Levin
On 07/23/2014 12:49 PM, Greg KH wrote: > On Wed, Jul 23, 2014 at 08:56:10AM -0400, Sasha Levin wrote: >> > Revert since the commit message is incorrect and the original author >> > refuses >> > to fix/maintain it because "it's in the kernel already". > How can someone "fix" a commit message that i

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-23 Thread Greg KH
On Wed, Jul 23, 2014 at 08:56:10AM -0400, Sasha Levin wrote: > Revert since the commit message is incorrect and the original author refuses > to fix/maintain it because "it's in the kernel already". How can someone "fix" a commit message that is already in the tree? You can't. The code part is c

[PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-23 Thread Sasha Levin
Revert since the commit message is incorrect and the original author refuses to fix/maintain it because "it's in the kernel already". Signed-off-by: Sasha Levin --- drivers/usb/core/hcd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c inde