Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 9:07 AM, Vlastimil Babka wrote: > On 07/23/2014 05:24 AM, Nick Krause wrote: >> >> On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin wrote: >>> >>> On 07/18/2014 10:52 PM, Nick Krause wrote: >> >> Please explain exactly why it's not needed, why it can never be NULL, >>>

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-24 Thread Vlastimil Babka
On 07/23/2014 05:24 AM, Nick Krause wrote: On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin wrote: On 07/18/2014 10:52 PM, Nick Krause wrote: Please explain exactly why it's not needed, why it can never be NULL, and what prevents it from being NULL. "after dicussing" (do you run spellcheck on you

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-22 Thread Nick Krause
On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin wrote: > On 07/18/2014 10:52 PM, Nick Krause wrote: >> On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause wrote: >>> Sorry didn't run spell check. I will resend this patch with the >>> correct information >>> as needed. Thanks for the advice, Sasha. >>> >>>

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-22 Thread Sasha Levin
On 07/18/2014 10:52 PM, Nick Krause wrote: > On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause wrote: >> Sorry didn't run spell check. I will resend this patch with the >> correct information >> as needed. Thanks for the advice, Sasha. >> >> Cheers Nick >> >> On Fri, Jul 18, 2014 at 10:36 PM, Sasha Le

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause wrote: > Sorry didn't run spell check. I will resend this patch with the > correct information > as needed. Thanks for the advice, Sasha. > > Cheers Nick > > On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin wrote: >> On 07/18/2014 01:34 PM, Nicholas Krau

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nick Krause
Sorry didn't run spell check. I will resend this patch with the correct information as needed. Thanks for the advice, Sasha. Cheers Nick On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin wrote: > On 07/18/2014 01:34 PM, Nicholas Krause wrote: >> I am removing two fix mes in this file as after dicuss

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Sasha Levin
On 07/18/2014 01:34 PM, Nicholas Krause wrote: > I am removing two fix mes in this file as after dicussing then it seems > there is no reason to check against Null for usb_device as it can never > be NULL and this is check is therefore not needed. > > Signed-off-by: Nicholas Krause Please expla

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 3:09 PM, Alan Stern wrote: > On Fri, 18 Jul 2014, Nicholas Krause wrote: > >> I am removing two fix mes in this file as after dicussing then it seems >> there is no reason to check against Null for usb_device as it can never >> be NULL and this is check is therefore not ne

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Alan Stern
On Fri, 18 Jul 2014, Nicholas Krause wrote: > I am removing two fix mes in this file as after dicussing then it seems > there is no reason to check against Null for usb_device as it can never > be NULL and this is check is therefore not needed. > > Signed-off-by: Nicholas Krause > --- > driver

[PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nicholas Krause
I am removing two fix mes in this file as after dicussing then it seems there is no reason to check against Null for usb_device as it can never be NULL and this is check is therefore not needed. Signed-off-by: Nicholas Krause --- drivers/usb/core/hcd.c | 4 1 file changed, 4 deletions(-)