Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Felipe Balbi
Hi again, On Mon, Nov 24, 2014 at 09:36:21AM -0600, Felipe Balbi wrote: > > > > > When __of_usb_find_phy() fails, it returns -ENODEV - its > > > > > error code has to be returned by devm_usb_get_phy_by_phandle(). > > > > > Only when the former function succeeds and try_module_get() > > > > > fails

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Felipe Balbi
Hi, On Mon, Nov 24, 2014 at 04:16:46PM +0100, Thierry Reding wrote: > On Mon, Nov 24, 2014 at 08:36:46AM -0600, Felipe Balbi wrote: > > Hi, > > > > On Mon, Nov 24, 2014 at 02:10:41PM +0100, Thierry Reding wrote: > > > On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > > > > When

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Thierry Reding
On Mon, Nov 24, 2014 at 08:36:46AM -0600, Felipe Balbi wrote: > Hi, > > On Mon, Nov 24, 2014 at 02:10:41PM +0100, Thierry Reding wrote: > > On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > > > When __of_usb_find_phy() fails, it returns -ENODEV - its > > > error code has to be re

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Felipe Balbi
Hi, On Mon, Nov 24, 2014 at 02:10:41PM +0100, Thierry Reding wrote: > On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > > When __of_usb_find_phy() fails, it returns -ENODEV - its > > error code has to be returned by devm_usb_get_phy_by_phandle(). > > Only when the former function

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Thierry Reding
On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > When __of_usb_find_phy() fails, it returns -ENODEV - its > error code has to be returned by devm_usb_get_phy_by_phandle(). > Only when the former function succeeds and try_module_get() > fails should -EPROBE_DEFER be returned. > >

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-21 Thread Felipe Balbi
On Fri, Nov 21, 2014 at 12:19:42PM +0530, Arjun Sreedharan wrote: > On 21 November 2014 01:09, Felipe Balbi wrote: > > > On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > > > When __of_usb_find_phy() fails, it returns -ENODEV - its > > > error code has to be returned by devm_usb

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-20 Thread Felipe Balbi
On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > When __of_usb_find_phy() fails, it returns -ENODEV - its > error code has to be returned by devm_usb_get_phy_by_phandle(). > Only when the former function succeeds and try_module_get() > fails should -EPROBE_DEFER be returned. > >

[PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-20 Thread Arjun Sreedharan
When __of_usb_find_phy() fails, it returns -ENODEV - its error code has to be returned by devm_usb_get_phy_by_phandle(). Only when the former function succeeds and try_module_get() fails should -EPROBE_DEFER be returned. Signed-off-by: Arjun Sreedharan --- drivers/usb/phy/phy.c | 4 +++- 1 file