Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-19 Thread Johan Hovold
On Wed, Jun 19, 2019 at 09:33:40AM +0300, Felipe Balbi wrote: > Johan Hovold writes: > > Are you sure you actually did register two xhci debug ttys? > > hmm, let me check: ... > Hmm, so it only really registers after writing to sysfs file. Man, this > is an odd driver :-) I hear you. :) > @M

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-19 Thread Mathias Nyman
On 19.6.2019 9.33, Felipe Balbi wrote: @Mathias, can you drop the previous fix? I'll try to come up with a better version of this. Dropped -Mathias

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-18 Thread Felipe Balbi
Hi, Johan Hovold writes: >> Johan Hovold writes: >> > On Tue, Jun 11, 2019 at 08:24:16PM +0300, Felipe Balbi wrote: >> >> If we happen to have two XHCI controllers with DbC capability, then >> >> there's no hope this will ever work as the global pointer will be >> >> overwritten by the controll

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-18 Thread Johan Hovold
On Mon, Jun 17, 2019 at 09:43:19AM +0300, Felipe Balbi wrote: > > Hi, > > Johan Hovold writes: > > On Tue, Jun 11, 2019 at 08:24:16PM +0300, Felipe Balbi wrote: > >> If we happen to have two XHCI controllers with DbC capability, then > >> there's no hope this will ever work as the global pointer

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-16 Thread Felipe Balbi
Hi, Johan Hovold writes: > On Tue, Jun 11, 2019 at 08:24:16PM +0300, Felipe Balbi wrote: >> If we happen to have two XHCI controllers with DbC capability, then >> there's no hope this will ever work as the global pointer will be >> overwritten by the controller that probes last. >> >> Avoid thi

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-14 Thread Johan Hovold
On Tue, Jun 11, 2019 at 08:24:16PM +0300, Felipe Balbi wrote: > If we happen to have two XHCI controllers with DbC capability, then > there's no hope this will ever work as the global pointer will be > overwritten by the controller that probes last. > > Avoid this problem by keeping the tty_driver

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-14 Thread Mathias Nyman
On 11.6.2019 20.24, Felipe Balbi wrote: If we happen to have two XHCI controllers with DbC capability, then there's no hope this will ever work as the global pointer will be overwritten by the controller that probes last. Avoid this problem by keeping the tty_driver struct pointer inside struct

[PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-11 Thread Felipe Balbi
If we happen to have two XHCI controllers with DbC capability, then there's no hope this will ever work as the global pointer will be overwritten by the controller that probes last. Avoid this problem by keeping the tty_driver struct pointer inside struct xhci_dbc. Fixes: dfba2174dc42 usb: xhci: