RE: [PATCH] usb: xhci: Optimise setup of isochronous transfers

2013-11-06 Thread David Laight
> -Original Message- > From: Andiry Xu [mailto:and...@gmail.com] > Sent: 05 November 2013 17:40 > To: David Laight > Cc: Linux-USB; Sarah Sharp > Subject: Re: [PATCH] usb: xhci: Optimise setup of isochronous transfers > > On Tue, Nov 5, 2013 at 6:21

Re: [PATCH] usb: xhci: Optimise setup of isochronous transfers

2013-11-05 Thread Andiry Xu
On Tue, Nov 5, 2013 at 6:21 AM, David Laight wrote: > > Close inspection shows that xhci_queue_isoc_tx() can only fail if > prepare_transfer() gets an error from usb_hcd_link_urb_to_ep() for > the first TD. The call to prepare_ring() cannot fail because an initial > check is made to ensure the rin

[PATCH] usb: xhci: Optimise setup of isochronous transfers

2013-11-05 Thread David Laight
Close inspection shows that xhci_queue_isoc_tx() can only fail if prepare_transfer() gets an error from usb_hcd_link_urb_to_ep() for the first TD. The call to prepare_ring() cannot fail because an initial check is made to ensure the ring has enough space for all the TD. The check for 'num_tds' be