> It's starting to get a bit too complicated.
> xhci find_new_dequeue_state() now has four places where it can toggle the
> cycle bit
> in addition to the cycle toggle in find_trb_seg().
>
> In the end we really just want to do it max once.
>
> I'll see if I can simplify the whole cycle bit code
On 07/17/2014 10:50 PM, Julius Werner wrote:
>> Hmm. Wouldn't it be safer to have a quirk for this, and only enable
>> the workaround if the Asmedia controller is detected? This code is so
>> complicated that it is difficult to see whether this could have a
>> harmful effect on controllers without
> Hmm. Wouldn't it be safer to have a quirk for this, and only enable
> the workaround if the Asmedia controller is detected? This code is so
> complicated that it is difficult to see whether this could have a
> harmful effect on controllers without the bug.
Sorry for making it complicated, but it
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Maciej Puzio
> Sent: Thursday, July 17, 2014 11:25 AM
>
> Tested-by: Maciej Puzio
>
> On Tue, Jul 8, 2014 at 2:01 PM, Julius Werner wrote:
> > Commit 1f81b6d22 "usb: xhci: Prefer endpoint context de
Tested-by: Maciej Puzio
On Tue, Jul 8, 2014 at 2:01 PM, Julius Werner wrote:
> Commit 1f81b6d22 "usb: xhci: Prefer endpoint context dequeue pointer
> over stopped_trb" changed the logic in xhci_find_new_dequeue_state() to
> only use the Endpoint Context's TR Dequeue Pointer instead of the last
>
Commit 1f81b6d22 "usb: xhci: Prefer endpoint context dequeue pointer
over stopped_trb" changed the logic in xhci_find_new_dequeue_state() to
only use the Endpoint Context's TR Dequeue Pointer instead of the last
Event TRB's TRB Pointer as a basis from which to infer the host
controller state. This
