Re: [PATCH] usb: otg: twl4030-usb: spin_unlock_irq in interrupt handler

2012-08-11 Thread Denis
On 09.08.2012 13:37, Felipe Balbi wrote: Hi, I have pushed a patch which I think solves this issue. Can you test ? Hi, my patch is unneeded since this is a threaded interrupt handler. And it runs with interrupt line masked globally on the controller(because of IRQF_ONESHOT). And I think that

Re: [PATCH] usb: otg: twl4030-usb: spin_unlock_irq in interrupt handler

2012-08-09 Thread Felipe Balbi
Hi, On Sat, Jul 21, 2012 at 11:40:18AM +0400, Denis Efremov wrote: > The replacement of spin_lock_irq/spin_unlock_irq pair in > twl4030_usb_linkstat function by > spin_lock_irqsave/spin_lock_irqrestore pair. > The twl4030_usb_linkstat function is called from twl4030_usb_irq > interrupt handler. Th

[PATCH] usb: otg: twl4030-usb: spin_unlock_irq in interrupt handler

2012-07-21 Thread Denis Efremov
The replacement of spin_lock_irq/spin_unlock_irq pair in twl4030_usb_linkstat function by spin_lock_irqsave/spin_lock_irqrestore pair. The twl4030_usb_linkstat function is called from twl4030_usb_irq interrupt handler. Therefore reenabling of handler interrupt line should be avoided. Found by Linu