From: Merlijn Wajer
This fixes an oops on unbind / module unload (on the musb omap2430
platform).
musb_remove function now calls musb_platform_exit before disabling
runtime pm.
Signed-off-by: Merlijn Wajer
Signed-off-by: Bin Liu
---
drivers/usb/musb/musb_core.c | 2 +-
1 file changed, 1 inse
On Thu, Mar 08, 2018 at 11:17:48PM +0100, Merlijn Wajer wrote:
> Hi,
>
> On 08/03/18 22:15, Bin Liu wrote:
>
> > please add patch version numbers in the subject when necessary. This
> > helps cross-referencing.
>
> Will do. I naively assumed that the first patch would implicitly be
> number 1. W
Hi,
On 08/03/18 22:15, Bin Liu wrote:
> please add patch version numbers in the subject when necessary. This
> helps cross-referencing.
Will do. I naively assumed that the first patch would implicitly be
number 1. Will send out v2 now.
>>
>> +musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
>
>
On Thu, Mar 08, 2018 at 09:40:47PM +0100, Merlijn Wajer wrote:
> This fixes an oops on unbind / module unload.
Please also mention here that it happens on omap2430 platform.
(omap2430 is the only platform affected by this bug.)
Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsu
Hi,
please add patch version numbers in the subject when necessary. This
helps cross-referencing.
On Thu, Mar 08, 2018 at 09:40:47PM +0100, Merlijn Wajer wrote:
> This fixes an oops on unbind / module unload.
>
> musb_remove function now calls musb_platform_exit before disabling
> runtime pm.
>
This fixes an oops on unbind / module unload.
musb_remove function now calls musb_platform_exit before disabling
runtime pm.
Signed-off-by: Merlijn Wajer
---
drivers/usb/musb/musb_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/driv
On Thu, Mar 08, 2018 at 07:00:16PM +0100, Merlijn Wajer wrote:
> Hi,
>
> On 08/03/18 17:46, Bin Liu wrote:
>
>
> > No need to flush, the work is already cancelled at this point.
> >
> >> +
> >>musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> >> + musb_platform_exit(musb);
> >
> > This can be m
Hi,
On 08/03/18 17:46, Bin Liu wrote:
> No need to flush, the work is already cancelled at this point.
>
>> +
>> musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
>> +musb_platform_exit(musb);
>
> This can be move down to out side of holding the spinlock,
>
>> spin_unlock_irqrestore(&mu
Hi,
On Thu, Mar 08, 2018 at 10:31:21AM +0100, Merlijn Wajer wrote:
> This fixes an oops on unbind / module unload. The fix is similar to the
> one in this commit: 0c3aae9bd59978fb8c3557d7883380bef0f2cfa1 (USB: musb:
> fix late external abort on suspend), which only fixes the issue for
> musb_suspe
This fixes an oops on unbind / module unload. The fix is similar to the
one in this commit: 0c3aae9bd59978fb8c3557d7883380bef0f2cfa1 (USB: musb:
fix late external abort on suspend), which only fixes the issue for
musb_suspend.
musb_remove function now also flushes any work and also calls
musb_plat
10 matches
Mail list logo
