Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-01 Thread Sergei Shtylyov
Hello. On 6/1/2015 1:41 AM, Colin Ian King wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Dereference, not "deference". Shall I send v2 for this stupid typo then? Definitely, especially as your chang

Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Colin Ian King
On 31/05/15 23:15, Sergei Shtylyov wrote: > Hello. > > On 06/01/2015 01:00 AM, Colin King wrote: > >> From: Colin Ian King > >> If kzalloc returns null then isp1760_ep_alloc_request performs >> a null pointer deference on req. > >Dereference, not "deference". Shall I send v2 for this stup

Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2015 01:00 AM, Colin King wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Dereference, not "deference". No, it doesn't. It calculates the address of the 'isp1760_request::req' instead, there

[PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Colin King
From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Check for null to avoid this. Detected with smatch static analysis: drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request() error: potential null dereference 'req'. (