Re: [PATCH] usb: gadget: s3c2410: fix clk resource leak and update

2013-05-11 Thread Libo Chen
于 2013-5-11 18:15, Tomasz Figa 写道: Hi Libo, On Saturday 11 of May 2013 14:28:15 Libo Chen wrote: >From: Libo Chen The patch subject is slightly misleading. It suggests that the patch only changes clock handling, but in fact the biggest part of the patch is conversion to devm_ helpers. I think

Re: [PATCH] usb: gadget: s3c2410: fix clk resource leak and update

2013-05-11 Thread Tomasz Figa
Hi Libo, On Saturday 11 of May 2013 14:28:15 Libo Chen wrote: > From: Libo Chen The patch subject is slightly misleading. It suggests that the patch only changes clock handling, but in fact the biggest part of the patch is conversion to devm_ helpers. I think following subject would suit this

[PATCH] usb: gadget: s3c2410: fix clk resource leak and update

2013-05-10 Thread Libo Chen
From: Libo Chen currently, when clk_get(NULL,"usb-device") fail, it does not disable && put usb_bus_clock. It is incorrect. this patch use new interface devm_xxx instead of xxx then we no need to care about cleanup resource in err case that is boring and reduce code size. Signed-off-by: Libo Ch