[PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-22 Thread Pavitrakumar Managutte
Removed usb_free_all_descriptors in the bind functions, which results in double-free corruption of the descriptors on error path. The usb descriptors are allocated by usb_assign_descriptors. Signed-off-by: Pavitrakumar Managutte Reviewed-by: Robert Baldyga Reviewed-by: Sebastian Andrzej Siewior

Re: Subject: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-13 Thread pavi1729 Sid
On Mon, Oct 13, 2014 at 6:55 PM, Robert Baldyga wrote: > Hi, > > "Subject: " at the beginning of your email subject looks unnecessary. > > When you're sending next version of your patch, you should add subject > prefix "[PATCH vN]", when N is number of version (eg. [PATCH v2]). See > Documentation

Re: Subject: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-13 Thread Robert Baldyga
Hi, "Subject: " at the beginning of your email subject looks unnecessary. When you're sending next version of your patch, you should add subject prefix "[PATCH vN]", when N is number of version (eg. [PATCH v2]). See Documentation/SubmittingPatches. ('git format-patch --subject-prefix' is helpful)

Subject: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-13 Thread pavi1729 Sid
Removed the usb_free_all_descriptors call in *_bind functions as this call is already present in usb_assign_descriptors. usb_assign_descriptors is the only call where usb descriptor allocation happens, also in case of error freeing of the allocated memory takes place in the same call. Hence the cal

Re: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-13 Thread pavi1729 Sid
On Mon, Oct 13, 2014 at 2:02 PM, Robert Baldyga wrote: > Hi, > > On 10/10/2014 03:09 PM, pavi1729 ivap wrote: >> From: Pavitra >> Date: Fri, 10 Oct 2014 16:05:30 +0530 >> Subject: [PATCH] usb: gadget: function: Remove redundant >> usb_free_

Re: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-13 Thread Robert Baldyga
Hi, On 10/10/2014 03:09 PM, pavi1729 ivap wrote: > From: Pavitra > Date: Fri, 10 Oct 2014 16:05:30 +0530 > Subject: [PATCH] usb: gadget: function: Remove redundant > usb_free_all_descriptors > > Removed the usb_free_all_descriptors call in *_bind functions > as this call

[PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-10 Thread pavi1729 ivap
From: Pavitra Date: Fri, 10 Oct 2014 16:05:30 +0530 Subject: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors Removed the usb_free_all_descriptors call in *_bind functions as this call is already present in usb_assign_descriptors. usb_assign_descriptors is the only call

Re: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-10 Thread pavi1729 ivap
avitra >>> Date: Fri, 10 Oct 2014 16:05:30 +0530 >>> Subject: [PATCH] usb: gadget: function: Remove redundant >>> usb_free_all_descriptors >>> >>> Removed the usb_free_all_descriptors call in *_bind functions >>> as this call is already present

Re: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-10 Thread pavi1729 ivap
0/2014 01:51 PM, pavi1729 ivap wrote: >>>From 3272817673910c63682e8b91ce0efaef190a399a Mon Sep 17 00:00:00 2001 >> From: Pavitra >> Date: Fri, 10 Oct 2014 16:05:30 +0530 >> Subject: [PATCH] usb: gadget: function: Remove redundant >> usb_free_all_descriptors >>

Re: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-10 Thread Robert Baldyga
Hi, On 10/10/2014 01:51 PM, pavi1729 ivap wrote: >>From 3272817673910c63682e8b91ce0efaef190a399a Mon Sep 17 00:00:00 2001 > From: Pavitra > Date: Fri, 10 Oct 2014 16:05:30 +0530 > Subject: [PATCH] usb: gadget: function: Remove redundant > usb_free_all_descriptor

[PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors

2014-10-10 Thread pavi1729 ivap
>From 3272817673910c63682e8b91ce0efaef190a399a Mon Sep 17 00:00:00 2001 From: Pavitra Date: Fri, 10 Oct 2014 16:05:30 +0530 Subject: [PATCH] usb: gadget: function: Remove redundant usb_free_all_descriptors Removed the usb_free_all_descriptors call in *_bind functions as this call is alre