Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-12-13 Thread Felipe Balbi
Hi, On Wed, Dec 12, 2012 at 10:13:27PM +0100, Linus Walleij wrote: > On Tue, Nov 27, 2012 at 3:11 PM, Linus Walleij > wrote: > > On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij > > wrote: > >> On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij > >> wrote: > >> > >>> From: Haipeng YU > >>> > >>> W

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-12-12 Thread Linus Walleij
On Tue, Nov 27, 2012 at 3:11 PM, Linus Walleij wrote: > On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij > wrote: >> On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij >> wrote: >> >>> From: Haipeng YU >>> >>> When a device is switched off by software, gserial_cleanup will >>> be called, and switch

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-27 Thread Greg Kroah-Hartman
On Tue, Nov 27, 2012 at 03:11:15PM +0100, Linus Walleij wrote: > On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij > wrote: > > On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij > > wrote: > > > >> From: Haipeng YU > >> > >> When a device is switched off by software, gserial_cleanup will > >> be call

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-27 Thread Linus Walleij
On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij wrote: > On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij > wrote: > >> From: Haipeng YU >> >> When a device is switched off by software, gserial_cleanup will >> be called, and switch off will be blocked in this function >> because wake_up_interruptib

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-21 Thread Linus Walleij
On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij wrote: > From: Haipeng YU > > When a device is switched off by software, gserial_cleanup will > be called, and switch off will be blocked in this function > because wake_up_interruptible() in gs_close() can not wake_up > the wait_event() in gserial_

[PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-14 Thread Linus Walleij
From: Haipeng YU When a device is switched off by software, gserial_cleanup will be called, and switch off will be blocked in this function because wake_up_interruptible() in gs_close() can not wake_up the wait_event() in gserial_cleanup(), it should be changed to wake_up() to match the wait_even