Re: [PATCH] usb: gadget: composite: fill bcdUSB for any gadget max speed

2015-08-19 Thread Igor Kotrasinski
On 08/19/2015 03:56 PM, Alan Stern wrote: > On Wed, 19 Aug 2015, Igor Kotrasinski wrote: > I would argue that there's no need to check gadget_is_dualspeed(); bcdUSB should always be set to 0x0200. After all, the spec explicitly permits USB-2.0 devices to run only at full speed. >>

Re: [PATCH] usb: gadget: composite: fill bcdUSB for any gadget max speed

2015-08-19 Thread Alan Stern
On Wed, 19 Aug 2015, Igor Kotrasinski wrote: > >> I would argue that there's no need to check gadget_is_dualspeed(); > >> bcdUSB should always be set to 0x0200. After all, the spec explicitly > >> permits USB-2.0 devices to run only at full speed. > > we should actually set it to 0x0210 so we get

Re: [PATCH] usb: gadget: composite: fill bcdUSB for any gadget max speed

2015-08-19 Thread Felipe Balbi
Hi, On Wed, Aug 19, 2015 at 11:00:54AM +0200, Igor Kotrasinski wrote: > > > On 08/18/2015 05:42 PM, Felipe Balbi wrote: > > On Tue, Aug 18, 2015 at 11:06:32AM -0400, Alan Stern wrote: > >> On Tue, 18 Aug 2015, Igor Kotrasinski wrote: > >> > >>> When handling device GET_DESCRIPTOR, composite gadg

Re: [PATCH] usb: gadget: composite: fill bcdUSB for any gadget max speed

2015-08-19 Thread Igor Kotrasinski
On 08/18/2015 05:42 PM, Felipe Balbi wrote: > On Tue, Aug 18, 2015 at 11:06:32AM -0400, Alan Stern wrote: >> On Tue, 18 Aug 2015, Igor Kotrasinski wrote: >> >>> When handling device GET_DESCRIPTOR, composite gadget driver fills >>> the bcdUSB field only if the gadget supports USB 3.0. Otherwise >

Re: [PATCH] usb: gadget: composite: fill bcdUSB for any gadget max speed

2015-08-18 Thread Felipe Balbi
On Tue, Aug 18, 2015 at 11:06:32AM -0400, Alan Stern wrote: > On Tue, 18 Aug 2015, Igor Kotrasinski wrote: > > > When handling device GET_DESCRIPTOR, composite gadget driver fills > > the bcdUSB field only if the gadget supports USB 3.0. Otherwise > > the field is left unfilled. > > > > Make beha

Re: [PATCH] usb: gadget: composite: fill bcdUSB for any gadget max speed

2015-08-18 Thread Alan Stern
On Tue, 18 Aug 2015, Igor Kotrasinski wrote: > When handling device GET_DESCRIPTOR, composite gadget driver fills > the bcdUSB field only if the gadget supports USB 3.0. Otherwise > the field is left unfilled. > > Make behaviour consistent by filling bcdUSB for the other two cases of > USB 2.0 an

[PATCH] usb: gadget: composite: fill bcdUSB for any gadget max speed

2015-08-18 Thread Igor Kotrasinski
When handling device GET_DESCRIPTOR, composite gadget driver fills the bcdUSB field only if the gadget supports USB 3.0. Otherwise the field is left unfilled. Make behaviour consistent by filling bcdUSB for the other two cases of USB 2.0 and USB 1.1 capable gadgets. Given that legacy gadget drive