Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-10-06 Thread gre...@linuxfoundation.org
On Tue, Oct 03, 2017 at 06:41:54PM +, Thinh Nguyen wrote: > Hi, > > On 9/11/2017 12:42 AM, Felipe Balbi wrote: > > > > Hi, > > > > Thinh Nguyen writes: > >>> Felipe Balbi writes: > Thinh Nguyen writes: > > > Hi Felipe, > > > > On 9/7/2017 12:16 AM, Felipe Balbi wrote

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-10-03 Thread Thinh Nguyen
Hi, On 9/11/2017 12:42 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >>> Felipe Balbi writes: Thinh Nguyen writes: > Hi Felipe, > > On 9/7/2017 12:16 AM, Felipe Balbi wrote: > drivers/usb/dwc3/gadget.c | 8 +--- > 1 file changed, 5

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-11 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >> Felipe Balbi writes: >>> Thinh Nguyen writes: >>> Hi Felipe, On 9/7/2017 12:16 AM, Felipe Balbi wrote: drivers/usb/dwc3/gadget.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/driv

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-08 Thread Thinh Nguyen
Hi, On 9/8/2017 2:34 AM, Felipe Balbi wrote: > Felipe Balbi writes: >> Thinh Nguyen writes: >> >>> Hi Felipe, >>> >>> On 9/7/2017 12:16 AM, Felipe Balbi wrote: >>> drivers/usb/dwc3/gadget.c | 8 +--- >>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --gi

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-08 Thread Felipe Balbi
Hi, Felipe Balbi writes: > Thinh Nguyen writes: > >> Hi Felipe, >> >> On 9/7/2017 12:16 AM, Felipe Balbi wrote: >>drivers/usb/dwc3/gadget.c | 8 +--- >>1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadg

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-08 Thread Felipe Balbi
Thinh Nguyen writes: > Hi Felipe, > > On 9/7/2017 12:16 AM, Felipe Balbi wrote: >drivers/usb/dwc3/gadget.c | 8 +--- >1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 9e41605a..6b299c7 100

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-07 Thread Thinh Nguyen
Hi Felipe, On 9/7/2017 12:16 AM, Felipe Balbi wrote: drivers/usb/dwc3/gadget.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 9e41605a..6b299c7 100644 --- a/drivers/usb/dwc3/g

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-07 Thread Felipe Balbi
Hi, Jack Pham writes: >> On 6/29/2017 12:54 AM, Jack Pham wrote: >> > A recent optimization was made so that a request put on the >> > pending_list wouldn't get mapped for DMA until just before >> > preparing a TRB for it. However, this poses a problem in case >> > the request is dequeued or the

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-06 Thread Jack Pham
On Thu, Sep 07, 2017 at 02:20:17AM +, Thinh Nguyen wrote: > Hi, > > On 6/29/2017 12:54 AM, Jack Pham wrote: > > A recent optimization was made so that a request put on the > > pending_list wouldn't get mapped for DMA until just before > > preparing a TRB for it. However, this poses a problem i

Re: [PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-09-06 Thread Thinh Nguyen
Hi, On 6/29/2017 12:54 AM, Jack Pham wrote: > A recent optimization was made so that a request put on the > pending_list wouldn't get mapped for DMA until just before > preparing a TRB for it. However, this poses a problem in case > the request is dequeued or the endpoint is disabled before the >

[PATCH] usb: dwc3: gadget: only unmap requests from DMA if mapped

2017-06-29 Thread Jack Pham
A recent optimization was made so that a request put on the pending_list wouldn't get mapped for DMA until just before preparing a TRB for it. However, this poses a problem in case the request is dequeued or the endpoint is disabled before the mapping is done as that would lead to dwc3_gadget_giveb