Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-03-01 Thread Felipe Balbi
On Fri, Mar 01, 2013 at 01:45:06PM +0530, Pratyush Anand wrote: > On 3/1/2013 12:10 PM, Felipe Balbi wrote: > >Hi, > > > > [...] > > >>dep->flags &= ~DWC3_EP_BUSY; > > > > ^ > > and here > > > >>udelay(100); > >>} > > > >?? > > Ohhh.. I missed this patch in my repo.. > > usb: dw

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-03-01 Thread Pratyush Anand
On 3/1/2013 12:10 PM, Felipe Balbi wrote: Hi, [...] dep->flags &= ~DWC3_EP_BUSY; ^ and here udelay(100); } ?? Ohhh.. I missed this patch in my repo.. usb: dwc3: gadget: fix 'endpoint always busy' bug -- To unsubscribe from this list: send the l

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 04:51:29PM +0530, Pratyush Anand wrote: > On 2/28/2013 4:18 PM, Felipe Balbi wrote: > >>+ if (list_empty(&dep->req_queued)) > >>>+ dep->flags &= ~DWC3_EP_BUSY; > >not sure this is correct. Whenever req_queue isn't empty, we call > >dwc3_stop_active_transfer()

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Pratyush Anand
On 2/28/2013 4:18 PM, Felipe Balbi wrote: + if (list_empty(&dep->req_queued)) >+ dep->flags &= ~DWC3_EP_BUSY; not sure this is correct. Whenever req_queue isn't empty, we call dwc3_stop_active_transfer() which will clear DWC3_EP_BUSY flag. Yes, if we clear DWC3_EP_BUSY in dwc3

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 04:05:31PM +0530, Pratyush Anand wrote: > To reproduce the issue: > > -- Gadget dequeues all submitted requests to the endpoint. > -- Some of them was not even queued to the dwc3 core. > -- Such requests will never complete and a transfer completion interrupt > for the

[PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Pratyush Anand
To reproduce the issue: -- Gadget dequeues all submitted requests to the endpoint. -- Some of them was not even queued to the dwc3 core. -- Such requests will never complete and a transfer completion interrupt for them will never be received. -- In such situation, we will not be clearing DWC3_EP_B