Re: [PATCH] usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()

2014-12-15 Thread Robert Baldyga
On 12/11/2014 08:34 PM, Paul Zimmerman wrote: >> From: Robert Baldyga [mailto:r.bald...@samsung.com] >> Sent: Tuesday, December 09, 2014 5:42 AM >> >> This makes us sure that all requests are completed before we unbind >> gadget. There are assumptions in gadget API that all requests have to >> be c

RE: [PATCH] usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()

2014-12-11 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Tuesday, December 09, 2014 5:42 AM > > This makes us sure that all requests are completed before we unbind > gadget. There are assumptions in gadget API that all requests have to > be completed and leak of complete can break some usb fu

[PATCH] usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()

2014-12-09 Thread Robert Baldyga
This makes us sure that all requests are completed before we unbind gadget. There are assumptions in gadget API that all requests have to be completed and leak of complete can break some usb function drivers. For example unbind of ECM function can cause NULL pointer dereference: [ 26.396595] co