Re: [PATCH] staging: dwc2: fix wrong setting of DMA masks

2013-03-23 Thread Felipe Balbi
Hi, On Fri, Mar 22, 2013 at 05:27:26PM -0700, Paul Zimmerman wrote: > We were setting the DMA masks in dwc2_driver_probe(), but that is > before the driver parameters have been set to their default values. > That meant the DMA masks could be set wrong. Fix it by moving the > DMA mask setting into

Re: [PATCH] staging: dwc2: fix wrong setting of DMA masks

2013-03-23 Thread Matthijs Kooijman
Hi Paul, > + /* Set device flags indicating whether the HCD supports DMA */ > + if (hsotg->core_params->dma_enable > 0) { > + if (dma_set_mask(hsotg->dev, DMA_BIT_MASK(32)) < 0) > + dev_warn(hsotg->dev, > + "can't enable workarou

[PATCH] staging: dwc2: fix wrong setting of DMA masks

2013-03-22 Thread Paul Zimmerman
We were setting the DMA masks in dwc2_driver_probe(), but that is before the driver parameters have been set to their default values. That meant the DMA masks could be set wrong. Fix it by moving the DMA mask setting into dwc2_hcd_init(), after the driver parameters have been set. This required a