Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-14 Thread Mark Brown
On Wed, Aug 14, 2013 at 09:19:44AM +0800, Peter Chen wrote: > If CONFIG_PM_SLEEP is not defined, the current value is .pm = NULL, > but your version .pm != NULL (its content is NULL). > I am not sure if it will cause any problems. It would cause a small amount of additional memory usage if the c

Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-13 Thread Peter Chen
On Tue, Aug 13, 2013 at 10:23 PM, Fabio Estevam wrote: > On Tue, Aug 13, 2013 at 11:05 AM, Peter Chen wrote: > >> But what I see is the &dwc3_pci_dev_pm_ops is not NULL if CONFIG_PM_SLEEP >> is not defined. > > The point of this macro is that we do not need to provide the .suspend > and .resume N

Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-13 Thread Fabio Estevam
On Tue, Aug 13, 2013 at 11:05 AM, Peter Chen wrote: > But what I see is the &dwc3_pci_dev_pm_ops is not NULL if CONFIG_PM_SLEEP > is not defined. The point of this macro is that we do not need to provide the .suspend and .resume NULL version when !CONFIG_PM_SLEEP because the macro takes care of

Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-13 Thread Peter Chen
On Tue, Aug 13, 2013 at 8:59 PM, Fabio Estevam wrote: > On Tue, Aug 13, 2013 at 3:59 AM, Peter Chen wrote: > >> It seems .pm is not NULL if CONFIG_PM_SLEEP is not defined >> which is not the same with former code. > > With SIMPLE_DEV_PM_OPS macro we don't need to define the NULL function > varia

Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-13 Thread Fabio Estevam
On Tue, Aug 13, 2013 at 3:59 AM, Peter Chen wrote: > It seems .pm is not NULL if CONFIG_PM_SLEEP is not defined > which is not the same with former code. With SIMPLE_DEV_PM_OPS macro we don't need to define the NULL function variants. Take a look at include/linux/pm.h to get a clear picture. --

Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-13 Thread Peter Chen
On Wed, Aug 7, 2013 at 7:51 PM, Fabio Estevam wrote: > From: Fabio Estevam > > Using SIMPLE_DEV_PM_OPS can make the code simpler and cleaner. > > Signed-off-by: Fabio Estevam > --- > drivers/usb/dwc3/dwc3-pci.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --

Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-12 Thread Mark Brown
On Wed, Aug 07, 2013 at 08:51:27AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Using SIMPLE_DEV_PM_OPS can make the code simpler and cleaner. > > Signed-off-by: Fabio Estevam Reviewed-by: Mark Brown signature.asc Description: Digital signature

[PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-07 Thread Fabio Estevam
From: Fabio Estevam Using SIMPLE_DEV_PM_OPS can make the code simpler and cleaner. Signed-off-by: Fabio Estevam --- drivers/usb/dwc3/dwc3-pci.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 5