Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-04 Thread Oliver Neukum
On Sa, 2019-03-02 at 15:36 +0100, Greg Kroah-Hartman wrote: > On Sat, Mar 02, 2019 at 02:51:41PM +0100, Oliver Neukum wrote: > > On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote: > > > On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > > > > On Fr, 2019-03-01 at 18:22 +0100,

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-02 Thread Greg Kroah-Hartman
On Sat, Mar 02, 2019 at 02:51:41PM +0100, Oliver Neukum wrote: > On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote: > > On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > > > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > > > > By moving one field around in 'st

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-02 Thread Oliver Neukum
On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > > > By moving one field around in 'struct urb' we reduce the size of the > > > structure by 8 bytes. > > >

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-02 Thread Greg Kroah-Hartman
On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > > By moving one field around in 'struct urb' we reduce the size of the > > structure by 8 bytes. > > If you are going for this I have to ask why unlink and status > are fu

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-01 Thread Oliver Neukum
On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > By moving one field around in 'struct urb' we reduce the size of the > structure by 8 bytes. If you are going for this I have to ask why unlink and status are full size ints anyway. Regards Oliver

[PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-01 Thread Greg Kroah-Hartman
By moving one field around in 'struct urb' we reduce the size of the structure by 8 bytes. Before the patch on x86_64 the overall size of the structure as reported by pahole was: /* size: 192, cachelines: 3, members: 30 */ /* sum members: 184, holes: 2, sum holes: 8 */ After the pa