Re: [PATCH] USB: serial: io_edgeport: fix up switch fall-through comments

2019-05-03 Thread Johan Hovold
On Fri, May 03, 2019 at 09:00:44AM -0500, Gustavo A. R. Silva wrote: > On 5/3/19 1:09 AM, Johan Hovold wrote: > > Gustavo, how many of these warnings are there left in the kernel now > > that the last one in USB is gone? :) > > > > Today, we woke up with 37 of these warnings left in linux-next.

Re: [PATCH] USB: serial: io_edgeport: fix up switch fall-through comments

2019-05-03 Thread Gustavo A. R. Silva
On 5/3/19 1:09 AM, Johan Hovold wrote: > On Thu, May 02, 2019 at 07:35:15PM +0200, Greg Kroah-Hartman wrote: >> Gustavo has been working to fix up all of the switch statements that >> "fall through" such that we can eventually turn on >> -Wimplicit-fallthrough. As part of that, the io_edgeport.

Re: [PATCH] USB: serial: io_edgeport: fix up switch fall-through comments

2019-05-02 Thread Johan Hovold
On Thu, May 02, 2019 at 07:35:15PM +0200, Greg Kroah-Hartman wrote: > Gustavo has been working to fix up all of the switch statements that > "fall through" such that we can eventually turn on > -Wimplicit-fallthrough. As part of that, the io_edgeport.c driver is a > bit "messy" with the parsing lo

Re: [PATCH] USB: serial: io_edgeport: fix up switch fall-through comments

2019-05-02 Thread Gustavo A. R. Silva
On 5/2/19 12:35 PM, Greg Kroah-Hartman wrote: > Gustavo has been working to fix up all of the switch statements that > "fall through" such that we can eventually turn on > -Wimplicit-fallthrough. As part of that, the io_edgeport.c driver is a > bit "messy" with the parsing logic of a data packe

[PATCH] USB: serial: io_edgeport: fix up switch fall-through comments

2019-05-02 Thread Greg Kroah-Hartman
Gustavo has been working to fix up all of the switch statements that "fall through" such that we can eventually turn on -Wimplicit-fallthrough. As part of that, the io_edgeport.c driver is a bit "messy" with the parsing logic of a data packet. Clean that logic up a bit by unindenting one level of