Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 11:18:50AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 11:10:20AM +0100, Johan Hovold wrote: > > On Wed, Dec 05, 2018 at 11:05:45AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > > > > > > Note that the

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 11:10:20AM +0100, Johan Hovold wrote: > On Wed, Dec 05, 2018 at 11:05:45AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > > > > Note that the changes to tty are trivial; I'm just renaming and > > > exporting an existing

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Jarkko Nikula
On 12/4/18 6:31 PM, Johan Hovold wrote: On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: The USB-serial console implementation has never reported the actual terminal settings used. Despite storing the corresponding

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 11:05:45AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > > Note that the changes to tty are trivial; I'm just renaming and > > exporting an existing helper. > > Yeah, I have no objections to them. We can take them in my

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 10:50:49AM +0100, Johan Hovold wrote: > On Wed, Dec 05, 2018 at 11:36:52AM +0200, Jarkko Nikula wrote: > > On 12/4/18 6:31 PM, Johan Hovold wrote: > > > On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: > > >> On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 11:36:52AM +0200, Jarkko Nikula wrote: > On 12/4/18 6:31 PM, Johan Hovold wrote: > > On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: > >> On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: > >>> The USB-serial console implementation has never r

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-04 Thread Johan Hovold
On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: > > The USB-serial console implementation has never reported the actual > > terminal settings used. Despite storing the corresponding cflags in its > > struct console,

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-04 Thread Greg Kroah-Hartman
On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: > The USB-serial console implementation has never reported the actual > terminal settings used. Despite storing the corresponding cflags in its > struct console, this was never honoured on later tty open() where the > tty termios would b

[PATCH] USB: serial: console: fix reported terminal settings

2018-12-04 Thread Johan Hovold
The USB-serial console implementation has never reported the actual terminal settings used. Despite storing the corresponding cflags in its struct console, this was never honoured on later tty open() where the tty termios would be left initialised to the driver defaults. Unlike the serial console