On Wed, 13 Dec 2017 15:39:21 +0100 Oliver Neukum wrote:
> But:
>
> device->maxbaudrate = 38400
>
> is better than
>
> device->maxbaudrate = MAX_BAUD
>
> You see the point?
Yes, I see. This is better, because it's more important to know =,
but not =.
thank you Oliver.
---
Mikhail
--
To un
Am Mittwoch, den 13.12.2017, 15:30 +0300 schrieb Mikhail Zaytsev:
> On Wed, 13 Dec 2017 12:40:48 +0100 Oliver Neukum wrote:
>
> >
> > They give you nothing. If you are looking at a vendor ID nothing but the
> > bare number makes sense. You are just making peoples' life harder when
> > they have
On Wed, 13 Dec 2017 12:40:48 +0100 Oliver Neukum wrote:
> They give you nothing. If you are looking at a vendor ID nothing but the
> bare number makes sense. You are just making peoples' life harder when
> they have to look up that definition. A symbolic name is fine if it gives
> meaning. Even i
Am Mittwoch, den 13.12.2017, 14:31 +0300 schrieb Mikhail Zaytsev:
> On Wed, 13 Dec 2017 11:17:28 +0100 Oliver Neukum wrote:
>
> >
> > Am Mittwoch, den 13.12.2017, 12:30 +0300 schrieb Mikhail Zaytsev:
> > >
> > > +#define RS232_VENDOR 0x6547
> > > +#define RS232_PRODUCT 0x0232
> > > +#define IRD
On Wed, 13 Dec 2017 11:17:28 +0100 Oliver Neukum wrote:
> Am Mittwoch, den 13.12.2017, 12:30 +0300 schrieb Mikhail Zaytsev:
> > +#define RS232_VENDOR 0x6547
> > +#define RS232_PRODUCT 0x0232
> > +#define IRDA_VENDOR 0x18ec
> > +#define IRDA_PRODUCT 0x3118
> >
> > /* usb timeout of 1 second */
On Wed, Dec 13, 2017 at 12:30:04PM +0300, Mikhail Zaytsev wrote:
> The patch removes unused TIOCSSERIAL case from ioctl. TIOCGSERIAL case
> moves to the get_serial_info() function. Some magic numbers moves to
> #define directives.
You need to split logical changes up in separate patches, and the
Am Mittwoch, den 13.12.2017, 12:30 +0300 schrieb Mikhail Zaytsev:
> +#define RS232_VENDOR 0x6547
> +#define RS232_PRODUCT 0x0232
> +#define IRDA_VENDOR 0x18ec
> +#define IRDA_PRODUCT 0x3118
>
> /* usb timeout of 1 second */
> #define ARK_TIMEOUT 1000
>
> static const struct usb_device_id id_
The patch removes unused TIOCSSERIAL case from ioctl. TIOCGSERIAL case
moves to the get_serial_info() function. Some magic numbers moves to
#define directives.
Signed-off-by: Mikhail Zaytsev
---
drivers/usb/serial/ark3116.c | 54 ++--
1 file changed, 32
The patch removes unused TIOCSSERIAL case from ioctl. TIOCGSERIAL case
moves to the get_serial_info() function. Any magic numbers moves to
#define directives.
Signed-off-by: Mikhail Zaytsev
---
drivers/usb/serial/ark3116.c | 54 ++--
1 file changed, 32 i
