Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-30 Thread Peter Hurley
On 10/30/2014 08:08 AM, Johan Hovold wrote: > Hi Peter, > > Forgot to reply to this one. > > On Wed, Oct 22, 2014 at 07:40:20AM -0400, Peter Hurley wrote: >> On 10/19/2014 01:12 PM, Johan Hovold wrote: >>> [ +CC: Jiri, Alan, linux-serial ] >>> >>> On Thu, Oct 16, 2014 at 02:09:29PM -0400, Peter H

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-30 Thread Johan Hovold
Hi Peter, Forgot to reply to this one. On Wed, Oct 22, 2014 at 07:40:20AM -0400, Peter Hurley wrote: > On 10/19/2014 01:12 PM, Johan Hovold wrote: > > [ +CC: Jiri, Alan, linux-serial ] > > > > On Thu, Oct 16, 2014 at 02:09:29PM -0400, Peter Hurley wrote: > >> On 10/16/2014 01:59 PM, Peter Hurley

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-22 Thread Peter Hurley
On 10/22/2014 08:07 AM, Joe Perches wrote: > On Wed, 2014-10-22 at 06:26 -0400, Peter Hurley wrote: >> On 10/22/2014 04:20 AM, Johan Hovold wrote: >>> On Thu, Oct 16, 2014 at 01:59:22PM -0400, Peter Hurley wrote: Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, "USB: kobil_sct: fix contro

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-22 Thread Joe Perches
On Wed, 2014-10-22 at 06:26 -0400, Peter Hurley wrote: > On 10/22/2014 04:20 AM, Johan Hovold wrote: > > On Thu, Oct 16, 2014 at 01:59:22PM -0400, Peter Hurley wrote: > >> Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, > >> "USB: kobil_sct: fix control requests without data stage", removed > > >

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-22 Thread Peter Hurley
On 10/19/2014 01:12 PM, Johan Hovold wrote: > [ +CC: Jiri, Alan, linux-serial ] > > On Thu, Oct 16, 2014 at 02:09:29PM -0400, Peter Hurley wrote: >> On 10/16/2014 01:59 PM, Peter Hurley wrote: >>> Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, >>> "USB: kobil_sct: fix control requests without da

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-22 Thread Peter Hurley
On 10/22/2014 04:20 AM, Johan Hovold wrote: > On Thu, Oct 16, 2014 at 01:59:22PM -0400, Peter Hurley wrote: >> Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, >> "USB: kobil_sct: fix control requests without data stage", removed > > checkpatch.pl complains on your commit-reference style so you kn

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-22 Thread Johan Hovold
On Thu, Oct 16, 2014 at 01:59:22PM -0400, Peter Hurley wrote: > Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, > "USB: kobil_sct: fix control requests without data stage", removed checkpatch.pl complains on your commit-reference style so you know. > the bogus data buffer arguments, but still al

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-19 Thread Johan Hovold
[ +CC: Jiri, Alan, linux-serial ] On Thu, Oct 16, 2014 at 02:09:29PM -0400, Peter Hurley wrote: > On 10/16/2014 01:59 PM, Peter Hurley wrote: > > Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, > > "USB: kobil_sct: fix control requests without data stage", removed > > the bogus data buffer argume

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-19 Thread Johan Hovold
On Thu, Oct 16, 2014 at 01:59:22PM -0400, Peter Hurley wrote: > Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, > "USB: kobil_sct: fix control requests without data stage", removed > the bogus data buffer arguments, but still allocate transfer > buffers which are not used. > > Cc: Johan Hovold >

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-16 Thread Peter Hurley
On 10/16/2014 01:59 PM, Peter Hurley wrote: > Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, > "USB: kobil_sct: fix control requests without data stage", removed > the bogus data buffer arguments, but still allocate transfer > buffers which are not used. > > Cc: Johan Hovold > Signed-off-by: Pe

[PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-16 Thread Peter Hurley
Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e, "USB: kobil_sct: fix control requests without data stage", removed the bogus data buffer arguments, but still allocate transfer buffers which are not used. Cc: Johan Hovold Signed-off-by: Peter Hurley --- drivers/usb/serial/kobil_sct.c | 15 -