Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Greg Kroah-Hartman
On Mon, Mar 14, 2016 at 12:46:26PM -0400, Josh Boyer wrote: > On Mon, Mar 14, 2016 at 12:15 PM, Greg Kroah-Hartman > wrote: > > On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: > >> The powermate driver expects at least one valid USB endpoint in its > >> probe function. If given malici

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Dmitry Torokhov
On Mon, Mar 14, 2016 at 9:46 AM, Josh Boyer wrote: > On Mon, Mar 14, 2016 at 12:15 PM, Greg Kroah-Hartman > wrote: >> On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: >>> The powermate driver expects at least one valid USB endpoint in its >>> probe function. If given malicious descrip

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Josh Boyer
On Mon, Mar 14, 2016 at 12:15 PM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: >> The powermate driver expects at least one valid USB endpoint in its >> probe function. If given malicious descriptors that specify 0 for >> the number of endpoints, it will

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Dmitry Torokhov
On Mon, Mar 14, 2016 at 09:15:48AM -0700, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: > > The powermate driver expects at least one valid USB endpoint in its > > probe function. If given malicious descriptors that specify 0 for > > the number of endpoint

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Greg Kroah-Hartman
On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: > The powermate driver expects at least one valid USB endpoint in its > probe function. If given malicious descriptors that specify 0 for > the number of endpoints, it will crash. Validate the number of > endpoints on the interface befor

[PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Josh Boyer
The powermate driver expects at least one valid USB endpoint in its probe function. If given malicious descriptors that specify 0 for the number of endpoints, it will crash. Validate the number of endpoints on the interface before using them. The full report for this issue can be found here: htt