Re: [PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Johan Hovold
On Tue, Nov 05, 2013 at 01:14:29PM +0100, Colin Leitner wrote: > > Comment style should be > > > > /* > > * ... > > */ > > I tried sticking to the style of the rest of the code but I'll keep that > in mind from now on. Wouldn't that be something checkpatch.pl could check? You'd thi

Re: [PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Colin Leitner
> Comment style should be > > /* >* ... >*/ I tried sticking to the style of the rest of the code but I'll keep that in mind from now on. Wouldn't that be something checkpatch.pl could check? > But I'm not sure you need to be that verbose in this case. You can > probably ju

Re: [PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Johan Hovold
On Tue, Nov 05, 2013 at 11:10:29AM +0100, Colin Leitner wrote: > FTDI UARTs support only 7 or 8 data dits. Until now the ftdi_sio driver would s/dits/bits/ > only report this limitation for CS6 to dmesg and fail to reflect this fact to > tcgetattr. > > This patch reverts the unsupported CSIZE set

[PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Colin Leitner
FTDI UARTs support only 7 or 8 data dits. Until now the ftdi_sio driver would only report this limitation for CS6 to dmesg and fail to reflect this fact to tcgetattr. This patch reverts the unsupported CSIZE setting and reports the fact with less severance to dmesg for both CS5 and CS6. To test t