On Fri, Dec 20, 2013 at 09:47:53PM -0500, Alan Stern wrote:
> On Fri, 20 Dec 2013, Greg Kroah-Hartman wrote:
>
> > > > /* Check that the pipe's type matches the endpoint's type */
> > > > if (usb_pipetype(urb->pipe) != pipetypes[xfertype])
> > >
> > > It looks as though it ought t
On Fri, 20 Dec 2013, Greg Kroah-Hartman wrote:
> > > /* Check that the pipe's type matches the endpoint's type */
> > > if (usb_pipetype(urb->pipe) != pipetypes[xfertype])
> >
> > It looks as though it ought to be possible to make that check:
> > if (unlikely(xfertype != urb->pipe->valid_
> From: Greg Kroah-Hartman
...
> > ...
> > > /* Check that the pipe's type matches the endpoint's type */
> > > if (usb_pipetype(urb->pipe) != pipetypes[xfertype])
> >
> > It looks as though it ought to be possible to make that check:
> > if (unlikely(xfertype != urb->pipe->valid_xfertype))
On Fri, Dec 20, 2013 at 10:04:00AM -, David Laight wrote:
> > From: Greg Kroah-Hartman
> > CONFIG_USB_DEBUG is going away, so remove the few places in the USB core
> > that relied on them.
> >
> > This means that we always now do the "debug" checks for every urb
> > submitted, which is a good
> From: Greg Kroah-Hartman
> CONFIG_USB_DEBUG is going away, so remove the few places in the USB core
> that relied on them.
>
> This means that we always now do the "debug" checks for every urb
> submitted, which is a good idea, as who knows how many driver bugs we
> have been ignoring when peopl
From: Greg Kroah-Hartman
CONFIG_USB_DEBUG is going away, so remove the few places in the USB core
that relied on them.
This means that we always now do the "debug" checks for every urb
submitted, which is a good idea, as who knows how many driver bugs we
have been ignoring when people forget to