Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-11-01 Thread Felipe Balbi
Hi, David Miller writes: > From: Ville Syrjälä > Date: Fri, 28 Oct 2016 19:33:32 +0300 > >> On Fri, Oct 28, 2016 at 01:16:13PM +0300, Felipe Balbi wrote: >>> Yeah, I'm guessing we're gonna need some help from networking folks. The >>> only thing we did since v4.7 was actually respect req->no_in

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-31 Thread David Miller
From: Ville Syrjälä Date: Fri, 28 Oct 2016 19:33:32 +0300 > On Fri, Oct 28, 2016 at 01:16:13PM +0300, Felipe Balbi wrote: >> Yeah, I'm guessing we're gonna need some help from networking folks. The >> only thing we did since v4.7 was actually respect req->no_interrupt flag >> coming from u_ether

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-28 Thread Ville Syrjälä
On Fri, Oct 28, 2016 at 01:16:13PM +0300, Felipe Balbi wrote: > > Hi, > > Ville Syrjälä writes: > > On Thu, Oct 06, 2016 at 12:08:26PM +0300, Ville Syrjälä wrote: > >> On Thu, Oct 06, 2016 at 10:36:09AM +0300, Felipe Balbi wrote: > >> > > >> > Hi, > >> > > >> > Felipe Balbi writes: > >> > >>

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-28 Thread Felipe Balbi
Hi, Ville Syrjälä writes: > On Thu, Oct 06, 2016 at 12:08:26PM +0300, Ville Syrjälä wrote: >> On Thu, Oct 06, 2016 at 10:36:09AM +0300, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Felipe Balbi writes: >> >> > Okay, I have found a regression on dwc3 and another patch follows: >> > >> > commi

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-27 Thread Ville Syrjälä
On Thu, Oct 06, 2016 at 12:08:26PM +0300, Ville Syrjälä wrote: > On Thu, Oct 06, 2016 at 10:36:09AM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Felipe Balbi writes: > > > Okay, I have found a regression on dwc3 and another patch follows: > > > > commit 5e1a2af3e46248c55098cdae643c4141851b70

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-06 Thread Felipe Balbi
Hi, Felipe Balbi writes: >>> >> Reverting that commit is not the best idea. Let's start with the usual: >>> >> >>> >> - Kernel version >>> >> - dmesg on both sides (host and device) >>> >> - dwc3 tracepoints: >>> >> >>> >> # mkdir -p /t >>> >> # mount -t tracefs none /t >>> >> # echo 8192 > /t

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-04 Thread Felipe Balbi
Hi, Ville Syrjälä writes: > On Tue, Oct 04, 2016 at 03:23:12PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Ville Syrjälä writes: >> > On Mon, Oct 03, 2016 at 07:08:43PM +0300, Felipe Balbi wrote: >> >> >> >> Hi, >> >> >> >> ville.syrj...@linux.intel.com writes: >> >> > From: Ville Syrjälä >

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-04 Thread Ville Syrjälä
On Tue, Oct 04, 2016 at 03:23:12PM +0300, Felipe Balbi wrote: > > Hi, > > Ville Syrjälä writes: > > On Mon, Oct 03, 2016 at 07:08:43PM +0300, Felipe Balbi wrote: > >> > >> Hi, > >> > >> ville.syrj...@linux.intel.com writes: > >> > From: Ville Syrjälä > >> > > >> > This reverts commit 55a0237f

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-04 Thread Felipe Balbi
Hi, Ville Syrjälä writes: > On Mon, Oct 03, 2016 at 07:08:43PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> ville.syrj...@linux.intel.com writes: >> > From: Ville Syrjälä >> > >> > This reverts commit 55a0237f8f47957163125e20ee9260538c5c341c. >> > >> > commit 55a0237f8f47 ("usb: dwc3: gadget:

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-04 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > ville.syrj...@linux.intel.com writes: >> From: Ville Syrjälä >> >> This reverts commit 55a0237f8f47957163125e20ee9260538c5c341c. >> >> commit 55a0237f8f47 ("usb: dwc3: gadget: use allocated/queued reqs for >> LST bit") causes my BYT FFRD8 with g_ether to behave

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-03 Thread Felipe Balbi
Hi, ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > This reverts commit 55a0237f8f47957163125e20ee9260538c5c341c. > > commit 55a0237f8f47 ("usb: dwc3: gadget: use allocated/queued reqs for > LST bit") causes my BYT FFRD8 with g_ether to behave poorly. ssh/scp > is very sluggish

[PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-03 Thread ville . syrjala
From: Ville Syrjälä This reverts commit 55a0237f8f47957163125e20ee9260538c5c341c. commit 55a0237f8f47 ("usb: dwc3: gadget: use allocated/queued reqs for LST bit") causes my BYT FFRD8 with g_ether to behave poorly. ssh/scp is very sluggish and can even stall entirely. Revert cures it. Cc: Felip