Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 04:33:42PM -0500, Jorge Ramirez-Ortiz wrote: > On 11/18/2014 03:47 PM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > > you have no clue what these mean, do you ? How about reading the USB > > specification

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 09:45:13PM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > > Sent: Tuesday, November 18, 2014 12:47 PM > > > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrot

RE: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Tuesday, November 18, 2014 12:47 PM > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > > > > notice that the original PLX driver was still far from the theo

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
On 11/18/2014 03:47 PM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > you have no clue what these mean, do you ? How about reading the USB > specification of even http://www.beyondlogic.org/usbnutshell/usb1.shtml Unfortunately I do

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
Hi, On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > >>> you have no clue what these mean, do you ? How about reading the USB > >>> specification of even http://www.beyondlogic.org/usbnutshell/usb1.shtml > >> > >> Unfortunately I do. > >> It was easier to temporarily hack the

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
On 11/18/2014 01:00 PM, Felipe Balbi wrote: > Hi, > > (fix your mailer, lines should be broken at 80-characters. > Documentation/email-clients.txt has tips) > > On Tue, Nov 18, 2014 at 12:52:11PM -0500, Jorge Ramirez-Ortiz wrote: >> On 11/18/2014 10:17 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Tue

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
Hi, (fix your mailer, lines should be broken at 80-characters. Documentation/email-clients.txt has tips) On Tue, Nov 18, 2014 at 12:52:11PM -0500, Jorge Ramirez-Ortiz wrote: > On 11/18/2014 10:17 AM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Nov 18, 2014 at 09:19:36AM -0500, Jorge Ramirez-Ortiz

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
On 11/18/2014 10:17 AM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 18, 2014 at 09:19:36AM -0500, Jorge Ramirez-Ortiz wrote: >> Hi Felipe/Greg >> >> Thanks for your comments on my previous attempt. >> I think I addressed them here. > no you haven't. Read Documentation/SubmittingPatches, read the mail

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
Hi, On Tue, Nov 18, 2014 at 09:19:36AM -0500, Jorge Ramirez-Ortiz wrote: > Hi Felipe/Greg > > Thanks for your comments on my previous attempt. > I think I addressed them here. no you haven't. Read Documentation/SubmittingPatches, read the mailing list archives and you'll see your basic mistake.

[PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
Hi Felipe/Greg Thanks for your comments on my previous attempt. I think I addressed them here. I added some logs of a run captured on a recent kernel, fixed the indentations, replaced the if/else with a switch statement and removed the copyright. Note that the tests seem to indicate a performance

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-17 Thread Jorge Ramirez-Ortiz
On 11/17/2014 07:54 PM, Greg KH wrote: > On Mon, Nov 17, 2014 at 06:30:28PM -0600, Felipe Balbi wrote: >> Hi, >> >> On Mon, Nov 17, 2014 at 06:19:54PM -0500, Jorge Ramirez-Ortiz wrote: >>> Hi, >>> >>> This patch adds USB3 support to the legacy gadget printer driver. >>> Applies cleanly on fc14f9c L

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-17 Thread Greg KH
On Mon, Nov 17, 2014 at 06:30:28PM -0600, Felipe Balbi wrote: > Hi, > > On Mon, Nov 17, 2014 at 06:19:54PM -0500, Jorge Ramirez-Ortiz wrote: > > Hi, > > > > This patch adds USB3 support to the legacy gadget printer driver. > > Applies cleanly on fc14f9c Linux 3.18-rc5. > > > > Please could it be

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-17 Thread Felipe Balbi
Hi, On Mon, Nov 17, 2014 at 06:19:54PM -0500, Jorge Ramirez-Ortiz wrote: > Hi, > > This patch adds USB3 support to the legacy gadget printer driver. > Applies cleanly on fc14f9c Linux 3.18-rc5. > > Please could it be considered for inclusion? sure, if you send it properly (see Documentation/Sub

[PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-17 Thread Jorge Ramirez-Ortiz
Hi, This patch adds USB3 support to the legacy gadget printer driver. Applies cleanly on fc14f9c Linux 3.18-rc5. Please could it be considered for inclusion? regards, Jorge >From f46d9b0d2160b30f14dee104657de865e9e2bc38 Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz Date: Thu, 25 Sep 201