Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-02 Thread Sergei Shtylyov
Hello. On 06/02/2015 06:41 PM, Laurent Pinchart wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. I told you there's no dereference and yet you're repeating it again. :-( How abou

Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-02 Thread Laurent Pinchart
On Monday 01 June 2015 16:51:30 Sergei Shtylyov wrote: > Hello. > > On 6/1/2015 1:43 AM, Colin King wrote: > > From: Colin Ian King > > > > If kzalloc returns null then isp1760_ep_alloc_request performs > > a null pointer dereference on req. Check for null to avoid this. > > I told you there's

Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-01 Thread Sergei Shtylyov
Hello. On 6/1/2015 1:43 AM, Colin King wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. I told you there's no dereference and yet you're repeating it again. :-( Detected with sm

[PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Colin King
From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. Detected with smatch static analysis: drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request() error: potential null dereference 'req'.