Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Sat, 27 Jun 2015, Greg Kroah-Hartman wrote: > On Fri, Jun 26, 2015 at 09:20:19PM -0400, Alan Stern wrote: > > My Apple keyboard isn't here at the moment, and I don't remember > > exactly what its hub descriptor contains. In theory, it _should_ mark > > the permanently attached port as non-remo

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Mon, 29 Jun 2015, Oliver Neukum wrote: > > This is a HW property and nothing kernel can do about. I am not saying it > > doesn't bring the LEDs up to a proper state again once auto-resumed. But I > > hate the LEDs going off a few seconds after I stop typing (i.e. once the > > keyboard gets a

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Mon, 2015-06-29 at 13:16 +0200, Jiri Kosina wrote: > On Mon, 29 Jun 2015, Oliver Neukum wrote: > > > > Last time we were testing this, autosuspend for USB HID devices was quite > > > a disaster. > > > > > > Do you have any idea whether udev developers tested the "autosuspend on > > > by > >

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Mon, 29 Jun 2015, Oliver Neukum wrote: > > Last time we were testing this, autosuspend for USB HID devices was quite > > a disaster. > > > > Do you have any idea whether udev developers tested the "autosuspend on by > > default for USB HID devices" on reasonable set of devices? > > > > The

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Sat, 2015-06-27 at 08:29 +0200, Jiri Kosina wrote: > On Fri, 26 Jun 2015, Greg Kroah-Hartman wrote: > Last time we were testing this, autosuspend for USB HID devices was quite > a disaster. > > Do you have any idea whether udev developers tested the "autosuspend on by > default for USB HID d

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Sat, Jun 27, 2015 at 08:29:16AM +0200, Jiri Kosina wrote: > On Fri, 26 Jun 2015, Greg Kroah-Hartman wrote: > > > > I thought udev used a whitelist of devices known to work okay with > > > autosuspend. Does it really turn on autosuspend for _every_ USB HID > > > device that is marked as remov

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Fri, 26 Jun 2015, Greg Kroah-Hartman wrote: > > I thought udev used a whitelist of devices known to work okay with > > autosuspend. Does it really turn on autosuspend for _every_ USB HID > > device that is marked as removable? > > Yes, it had a tiny whitelist of 3-4 devices, and then would

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Fri, Jun 26, 2015 at 09:20:19PM -0400, Alan Stern wrote: > On Fri, 26 Jun 2015, Greg Kroah-Hartman wrote: > > > > This doesn't do what the patch title says. USB_DEVICE_FIXED means that > > > the device can't be unplugged from its upstream port. It doesn't mean > > > the device is internal to

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Fri, 26 Jun 2015, Greg Kroah-Hartman wrote: > > This doesn't do what the patch title says. USB_DEVICE_FIXED means that > > the device can't be unplugged from its upstream port. It doesn't mean > > the device is internal to the computer. > > > > As an example, consider a composite Apple keybo

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Fri, Jun 26, 2015 at 04:08:20PM -0400, Alan Stern wrote: > On Fri, 26 Jun 2015, Tom Gundersen wrote: > > > This policy used to be unconditionally applied by udev, but there > > is no reason to make userspace be involved in this and in the future > > udev will not be doing it by default. > > >

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Fri, 26 Jun 2015, Alan Stern wrote: > On Fri, 26 Jun 2015, Tom Gundersen wrote: > > > This policy used to be unconditionally applied by udev, but there > > is no reason to make userspace be involved in this and in the future > > udev will not be doing it by default. > > > > See:

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Fri, 26 Jun 2015, Tom Gundersen wrote: > This policy used to be unconditionally applied by udev, but there > is no reason to make userspace be involved in this and in the future > udev will not be doing it by default. > > See: . > > Signed-off-by:

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

On Fri, Jun 26, 2015 at 09:24:07PM +0200, Tom Gundersen wrote: > This policy used to be unconditionally applied by udev, but there > is no reason to make userspace be involved in this and in the future > udev will not be doing it by default. > > See: .

[PATCH][RFC] usbhid: enable autosuspend for internal devices

This policy used to be unconditionally applied by udev, but there is no reason to make userspace be involved in this and in the future udev will not be doing it by default. See: . Signed-off-by: Tom Gundersen Cc: Jiri Kosina Cc: Greg Kroah-Hartman -